mirror of
https://github.com/NixOS/nixpkgs.git
synced 2024-11-22 05:31:22 +00:00
5c59da48e4
Per https://github.com/NixOS/nixpkgs/pull/58147#issuecomment-478234495 sandboxing is not fully functional on macOS. .github: specify where sandboxing can be run Co-Authored-By: Jon <jonringer@users.noreply.github.com> .github: remove macOS note
24 lines
1.8 KiB
Markdown
24 lines
1.8 KiB
Markdown
<!-- Nixpkgs has a lot of new incoming Pull Requests, but not enough people to review this constant stream. Even if you aren't a committer, we would appreciate reviews of other PRs, especially simple ones like package updates. Just testing the relevant package/service and leaving a comment saying what you tested, how you tested it and whether it worked would be great. List of open PRs: <https://github.com/NixOS/nixpkgs/pulls>, for more about reviewing contributions: <https://hydra.nixos.org/job/nixpkgs/trunk/manual/latest/download/1/nixpkgs/manual.html#chap-reviewing-contributions>. Reviewing isn't mandatory, but it would help out a lot and reduce the average time-to-merge for all of us. Thanks a lot if you do! -->
|
|
###### Motivation for this change
|
|
|
|
|
|
###### Things done
|
|
|
|
<!-- Please check what applies. Note that these are not hard requirements but merely serve as information for reviewers. -->
|
|
|
|
- [ ] Tested using sandboxing ([nix.useSandbox](http://nixos.org/nixos/manual/options.html#opt-nix.useSandbox) on NixOS, or option `sandbox` in [`nix.conf`](http://nixos.org/nix/manual/#sec-conf-file) on non-NixOS linux)
|
|
- Built on platform(s)
|
|
- [ ] NixOS
|
|
- [ ] macOS
|
|
- [ ] other Linux distributions
|
|
- [ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside [nixos/tests](https://github.com/NixOS/nixpkgs/blob/master/nixos/tests))
|
|
- [ ] Tested compilation of all pkgs that depend on this change using `nix-shell -p nix-review --run "nix-review wip"`
|
|
- [ ] Tested execution of all binary files (usually in `./result/bin/`)
|
|
- [ ] Determined the impact on package closure size (by running `nix path-info -S` before and after)
|
|
- [ ] Ensured that relevant documentation is up to date
|
|
- [ ] Fits [CONTRIBUTING.md](https://github.com/NixOS/nixpkgs/blob/master/.github/CONTRIBUTING.md).
|
|
|
|
###### Notify maintainers
|
|
|
|
cc @
|