1
0
Fork 1
mirror of https://github.com/NixOS/nixpkgs.git synced 2024-12-25 03:17:13 +00:00
nixpkgs/.github/PULL_REQUEST_TEMPLATE.md
Americo 5c59da48e4
.github: clarify things done re: sandboxing
Per https://github.com/NixOS/nixpkgs/pull/58147#issuecomment-478234495
sandboxing is not fully functional on macOS.

.github: specify where sandboxing can be run

Co-Authored-By: Jon <jonringer@users.noreply.github.com>

.github: remove macOS note
2019-10-30 11:32:29 -07:00

1.8 KiB

Motivation for this change
Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.
Notify maintainers

cc @