mirrors/nixpkgs
1
0
Fork 1
mirror of https://github.com/NixOS/nixpkgs.git synced 2024-11-25 07:00:43 +00:00
Code Issues Wiki Activity
nixpkgs/.github/PULL_REQUEST_TEMPLATE.md
Las Safin 629f88f3af
PULL_REQUEST_TEMPLATE.md: Improve platform checkboxes 
1) Building with the sandbox enabled is the standard on Linux,
   so it is of little relevance with distribution they are using.
   Because of this, we now specify "Linux" instead of "NixOS",
   and the sandbox checkbox specifies "non-Linux".
2) aarch64 is a much more common platform, so we add two separate
   checkboxes for both aarch64-linux and aarch64-darwin.
3) The platform names now match what is actually used by Nix.
2021-08-19 13:01:59 +00:00

1.7 KiB
Raw Blame History

Motivation for this change
Things done
  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandbox = true set in nix.conf? (See Nix manual)
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • 21.11 Release Notes (or backporting 21.05 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.