queer-af/mastodon
1
0
Fork 0
Code Issues Pull requests Projects Releases Wiki Activity

Fix batch actions on non-pending tags in admin interface (#12537)

Browse source 
- Allow batch actions on unreviewed tags
- Hide checkboxes when batch actions aren't available
This commit is contained in:
ThibG 2019-12-29 05:41:26 +01:00 committed by Eugen Rochko
parent 31f7c3fc5d
commit 162dc845a0
2 changed files with 11 additions and 9 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

1
app/views/admin/tags/_tag.html.haml
View file

@ -1,4 +1,5 @@
.batch-table__row .batch-table__row
- if batch_available
%label.batch-table__row__select.batch-table__row__select--aligned.batch-checkbox %label.batch-table__row__select.batch-table__row__select--aligned.batch-checkbox
= f.check_box :tag_ids, { multiple: true, include_hidden: false }, tag.id = f.check_box :tag_ids, { multiple: true, include_hidden: false }, tag.id

7
app/views/admin/tags/index.html.haml
View file

@ -50,25 +50,26 @@
.batch-table.optional .batch-table.optional
.batch-table__toolbar .batch-table__toolbar
- if params[:pending_review] == '1' || params[:unreviewed] == '1'
%label.batch-table__toolbar__select.batch-checkbox-all %label.batch-table__toolbar__select.batch-checkbox-all
= check_box_tag :batch_checkbox_all, nil, false = check_box_tag :batch_checkbox_all, nil, false
.batch-table__toolbar__actions .batch-table__toolbar__actions
- if params[:pending_review] == '1'
= f.button safe_join([fa_icon('check'), t('admin.accounts.approve')]), name: :approve, class: 'table-action-link', type: :submit, data: { confirm: t('admin.reports.are_you_sure') } = f.button safe_join([fa_icon('check'), t('admin.accounts.approve')]), name: :approve, class: 'table-action-link', type: :submit, data: { confirm: t('admin.reports.are_you_sure') }
= f.button safe_join([fa_icon('times'), t('admin.accounts.reject')]), name: :reject, class: 'table-action-link', type: :submit, data: { confirm: t('admin.reports.are_you_sure') } = f.button safe_join([fa_icon('times'), t('admin.accounts.reject')]), name: :reject, class: 'table-action-link', type: :submit, data: { confirm: t('admin.reports.are_you_sure') }
- else - else
.batch-table__toolbar__actions
%span.neutral-hint= t('generic.no_batch_actions_available') %span.neutral-hint= t('generic.no_batch_actions_available')
.batch-table__body .batch-table__body
- if @tags.empty? - if @tags.empty?
= nothing_here 'nothing-here--under-tabs' = nothing_here 'nothing-here--under-tabs'
- else - else
= render partial: 'tag', collection: @tags, locals: { f: f } = render partial: 'tag', collection: @tags, locals: { f: f, batch_available: params[:pending_review] == '1' || params[:unreviewed] == '1' }
= paginate @tags = paginate @tags
- if params[:pending_review] == '1' - if params[:pending_review] == '1' || params[:unreviewed] == '1'
%hr.spacer/ %hr.spacer/
%div{ style: 'overflow: hidden' } %div{ style: 'overflow: hidden' }