queer-af/mastodon
1
0
Fork 0
Code Issues Pull requests Projects Releases Wiki Activity

Refactor race condition reblog service spec (#24526)

Browse source
This commit is contained in:
Matt Jankowski 2023-04-14 08:42:10 -04:00 committed by GitHub
parent b0800d602e
commit 10f0de4212
No known key found for this signature in database
GPG key ID: 4AEE18F83AFDEB23
1 changed files with 17 additions and 5 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

22
spec/services/reblog_service_spec.rb
View file

@ -35,13 +35,25 @@ RSpec.describe ReblogService, type: :service do
end end
context 'when the reblogged status is discarded in the meantime' do context 'when the reblogged status is discarded in the meantime' do
let(:status) { Fabricate(:status, account: alice, visibility: :public) } let(:status) { Fabricate(:status, account: alice, visibility: :public, text: 'discard-status-text') }
# Add a callback to discard the status being reblogged after the
# validations pass but before the database commit is executed.
before do before do
# Update the in-database attribute without reflecting the change in Status.class_eval do
# the object. This cannot simulate all race conditions, but it is before_save :discard_status
# pretty close. def discard_status
Status.where(id: status.id).update_all(deleted_at: Time.now.utc) # rubocop:disable Rails/SkipsModelValidations Status
.where(id: reblog_of_id)
.where(text: 'discard-status-text')
.update_all(deleted_at: Time.now.utc) # rubocop:disable Rails/SkipsModelValidations
end
end
end
# Remove race condition simulating `discard_status` callback.
after do
Status._save_callbacks.delete(:discard_status)
end end
it 'raises an exception' do it 'raises an exception' do