1
0
Fork 1
mirror of https://github.com/NixOS/nixpkgs.git synced 2024-12-06 12:33:51 +00:00
nixpkgs/pkgs/applications
Greg Price 45a04ed6d4 gbsplay: fix configure flags
This caused none of these flags to have any effect.  That's because
the configure command looked like this:

    ./configure --prefix=/nix/store/svhl0fjdj1jl2sqcppy5vnzpfi4gj3d3-gbsplay-2016-12-17 \
        --without-test\ --without-contrib\ --disable-devdsp\ --enable-pulse\ --disable-alsa\ --disable-midi\ --disable-nas\ --disable-dsound\ --disable-i18n

with one giant flag '--without-test --without-contrib...', containing
internal spaces.

This can be seen in `nix log nixpkgs.gbsplay`, in this line:

    configure flags: --prefix=/nix/store/svhl0fjdj1jl2sqcppy5vnzpfi4gj3d3-gbsplay-2016-12-17 --without-test\ --without-contrib\ --disable-devdsp\ --enable-pulse\ --disable-alsa\ --disable-midi\ --disable-nas\ --disable-dsound\ --disable-i18n

and then in the fact that features like "devdsp" and "midi" are listed
as enabled in later output, and source files like plugout_midi.c are
included in the build.

I don't have a real opinion on whether it's better to have these flags
or not, but it's clear the author's intention was to pass them.  So,
fix the attr name so they get passed.
2020-04-21 07:51:55 +02:00
..
accessibility contrast: 0.0.2 -> 0.0.3 2020-04-19 13:09:15 -04:00
audio gbsplay: fix configure flags 2020-04-21 07:51:55 +02:00
backup treewide: Per RFC45, remove all unquoted URLs 2020-04-10 17:54:53 +01:00
blockchains go-ethereum: 1.9.12 -> 1.9.13 2020-04-17 08:14:02 +08:00
display-managers Merge pull request #84255 from prikhi/lightdm-mini-greeter-040 2020-04-14 08:38:23 -04:00
editors Merge pull request #84785 from mikesperber/unbreak-emacs-macos 2020-04-20 10:57:17 -07:00
gis treewide: Per RFC45, remove all unquoted URLs 2020-04-10 17:54:53 +01:00
graphics Merge branch 'master' into staging-next 2020-04-18 07:42:26 +02:00
kde Add myself (turion) to the maintainers list for several packages 2020-04-19 13:14:31 +02:00
misc Merge pull request #85605 from oxalica/bump/birdtray 2020-04-20 21:27:07 -05:00
networking cni-plugins: 0.8.4 -> 0.8.5 2020-04-21 09:29:29 +10:00
office Merge pull request #85572 from helsinki-systems/libreoffice 2020-04-20 00:55:19 +00:00
qubes/qubes-core-vchan-xen
radio treewide: use blas and lapack 2020-04-17 16:24:09 -05:00
science Merge pull request #85006 from r-ryantm/auto-update/verilator 2020-04-20 16:51:31 +02:00
search treewide: Per RFC45, remove all unquoted URLs 2020-04-10 17:54:53 +01:00
system monitor: add note how to use indicator. 2020-04-16 01:11:27 -04:00
version-management Merge pull request #84823 from aanderse/redmine-master 2020-04-19 15:51:10 -04:00
video plex-media-player: 2.40.0.1007 -> 2.55.0.1069 + update script (#68938) 2020-04-20 10:40:00 +01:00
virtualization Merge pull request #85526 from zowoq/misc 2020-04-19 19:26:41 -05:00
window-managers icewm: update URL 2020-04-15 00:34:30 -03:00