1
0
Fork 1
mirror of https://github.com/NixOS/nixpkgs.git synced 2024-11-18 11:40:45 +00:00
nixpkgs/pkgs
Graham Christensen c2b898da76 treewide: drop -l$NIX_BUILD_CORES
Passing `-l$NIX_BUILD_CORES` improperly limits the overall system load.

For a build machine which is configured to run `$B` builds where each
build gets `total cores / B` cores (`$C`), passing `-l $C` to make will
improperly limit the load to `$C` instead of `$B * $C`.

This effect becomes quite pronounced on machines with 80 cores, with
40 simultaneous builds and a cores limit of 2. On a machine with this
configuration, Nix will run 40 builds and make will limit the overall
system load to approximately 2. A build machine with this many cores
can happily run with a load approaching 80.

A non-solution is to oversubscribe the machine, by picking a larger
`$C`. However, there is no way to divide the number of cores in a way
which fairly subdivides the available cores when `$B` is greater than
1.

There has been exploration of passing a jobserver in to the sandbox,
or sharing a jobserver between all the builds. This is one option, but
relatively complicated and only supports make. Lots of other software
uses its own implementation of `-j` and doesn't support either `-l` or
the Make jobserver.

For the case of an interactive user machine, the user should limit
overall system load using `$B`, `$C`, and optionally systemd's
cpu/network/io limiting features.

Making this change should significantly improve the utilization of our
build farm, and improve the throughput of Hydra.
2022-09-22 16:01:23 -04:00
..
applications treewide: drop -l$NIX_BUILD_CORES 2022-09-22 16:01:23 -04:00
build-support
common-updater
data Merge staging-next into staging 2022-09-21 18:02:00 +00:00
desktops Merge master into staging-next 2022-09-21 18:01:25 +00:00
development treewide: drop -l$NIX_BUILD_CORES 2022-09-22 16:01:23 -04:00
games treewide: drop -l$NIX_BUILD_CORES 2022-09-22 16:01:23 -04:00
misc
os-specific treewide: drop -l$NIX_BUILD_CORES 2022-09-22 16:01:23 -04:00
pkgs-lib
servers Merge staging-next into staging 2022-09-22 06:20:23 +00:00
shells
stdenv treewide: drop -l$NIX_BUILD_CORES 2022-09-22 16:01:23 -04:00
test
tools treewide: drop -l$NIX_BUILD_CORES 2022-09-22 16:01:23 -04:00
top-level Merge staging-next into staging 2022-09-22 00:03:56 +00:00