mirror of
https://github.com/NixOS/nixpkgs.git
synced 2024-11-22 05:31:22 +00:00
311aa5d8d9
This should fix #7366 for now, but using the (IMHO) pragmatic approach of extending the sed expression to recognize strings. However, this approach is obviously not parsing the full AST, nor does it wrap Python itself (as pointed out by @spwhitt in #7366) but tries to match Python strings as best as possible without getting TOO unreadable. We also use a little bit of Nix to help generating the SED expression, because doing the whole quote matching block over and over again would be quite repetitious and error-prone to change. The reason why I'm using imap here is that we need to have unique labels to avoid jumping into the wrong branch. So the new expression is not only able to match continous regions of triple-quoted strings, but also regions with only one quote character (even with escaped inner quotes) and empty strings. However, what it doesn't correctly recognize is something like this: "string1" "string2" "multi line string" Which is very unlikely that we'll find something like this in the wild. Of course, we could handle it as well, but it would mean that we need to substitute the current line into hold space until we're finished parsing the strings, branch off to another label where we match multiline strings of all sorts and swap hold/pattern space and finally print the result. So to summarize: The SED expression would be 3 to 4 times bigger than now and we gain very little from that. Signed-off-by: aszlig <aszlig@redmoonstudios.org> |
||
|---|---|---|
| .. | ||
| all-packages.nix | ||
| emacs-packages.nix | ||
| go-packages.nix | ||
| guile-2-test.nix | ||
| haskell-defaults.nix | ||
| haskell-ng.nix | ||
| haskell-packages.nix | ||
| lua-packages.nix | ||
| make-tarball.nix | ||
| node-packages-generated.nix | ||
| node-packages.json | ||
| node-packages.nix | ||
| perl-packages.nix | ||
| php-packages.nix | ||
| platforms.nix | ||
| python-packages-generated.nix | ||
| python-packages.json | ||
| python-packages.nix | ||
| release-cross.nix | ||
| release-lib.nix | ||
| release-python.nix | ||
| release-small.nix | ||
| release.nix | ||