mirror of
https://github.com/NixOS/nixpkgs.git
synced 2024-12-25 03:17:13 +00:00
d2af4c6722
In 2942815968, the dependencies for Qt 5
were passed using buildEnv with all the development binaries, headers
and libs. Unfortunately, the build output references that environment
which also increases the size of the runtime closure.
The upstream makefile assumes a common Qt 5 library path, but that's not
the case within Nix, because we have separate paths for the Qt 5
modules.
We now patch the makefile to recognize PATH_QT5_X11_EXTRAS_{LIB,INC} so
that we can pass in the relevant paths from Qt5X11Extras.
In summary, the closure size goes down to 525559600 bytes (501 MB)
instead of 863035544 bytes (823 MB) with vbox-qt5-env.
Signed-off-by: aszlig <aszlig@redmoonstudios.org>
32 lines
1.6 KiB
Diff
32 lines
1.6 KiB
Diff
diff --git a/kBuild/units/qt5.kmk b/kBuild/units/qt5.kmk
|
|
index 71b96a3..73391f0 100644
|
|
--- a/kBuild/units/qt5.kmk
|
|
+++ b/kBuild/units/qt5.kmk
|
|
@@ -994,9 +994,10 @@ else
|
|
$(eval $(target)_LIBS += $(PATH_SDK_QT5_LIB)/$(qt_prefix)qtmain$(qt_infix)$(SUFF_LIB) )
|
|
endif
|
|
else
|
|
- $(eval $(target)_LIBS += $(foreach module,$(qt_modules), $(PATH_SDK_QT5_LIB)/lib$(qt_prefix)Qt5$(module)$(qt_infix)$(SUFF_DLL)) )
|
|
+ $(eval $(target)_LIBS += $(foreach module,$(qt_modules), $(PATH_SDK_QT5_LIB)/lib$(qt_prefix)Qt5$(module)$(qt_infix)$(SUFF_DLL)) \
|
|
+ $(PATH_QT5_X11_EXTRAS_LIB)/lib$(qt_prefix)Qt5X11Extras$(qt_infix)$(SUFF_DLL))
|
|
endif
|
|
- $(eval $(target)_INCS += $(addprefix $(PATH_SDK_QT5_INC)/Qt,$(qt_modules)) $(PATH_SDK_QT5_INC) )
|
|
+ $(eval $(target)_INCS += $(addprefix $(PATH_SDK_QT5_INC)/Qt,$(qt_modules)) $(PATH_SDK_QT5_INC) $(PATH_QT5_X11_EXTRAS_INC)/QtX11Extras )
|
|
endif
|
|
$(eval $(target)_DEFS += $(foreach module,$(toupper $(qt_modules)), QT_$(module)_LIB) )
|
|
|
|
diff --git a/src/VBox/Frontends/VirtualBox/Makefile.kmk b/src/VBox/Frontends/VirtualBox/Makefile.kmk
|
|
index 38db6b0..7dd446b 100644
|
|
--- a/src/VBox/Frontends/VirtualBox/Makefile.kmk
|
|
+++ b/src/VBox/Frontends/VirtualBox/Makefile.kmk
|
|
@@ -912,9 +912,6 @@ VirtualBox_QT_MODULES = Core Gui
|
|
ifdef VBOX_WITH_QTGUI_V5
|
|
# Qt5 requires additional modules:
|
|
VirtualBox_QT_MODULES += Widgets PrintSupport
|
|
- VirtualBox_QT_MODULES.linux += X11Extras
|
|
- VirtualBox_QT_MODULES.solaris += X11Extras
|
|
- VirtualBox_QT_MODULES.freebsd += X11Extras
|
|
VirtualBox_QT_MODULES.darwin += MacExtras
|
|
VirtualBox_QT_MODULES.win += WinExtras
|
|
endif # VBOX_WITH_QTGUI_V5
|