1
0
Fork 1
mirror of https://github.com/NixOS/nixpkgs.git synced 2024-11-30 09:31:01 +00:00
nixpkgs/nixos/modules
rnhmjoj 9be0529210
nixos/console: fix console setting reloading
It's a dull and boring day, it's cold outside and I'm stuck at home: let
me tell you the story of systemd-vconsole-setup.

In the beginnings of NixOS[1], systemd-vconsole-setup was a powerful
sysinit.target unit, installed and running at boot to set up fonts
keyboard layouts and even colors of the virtual consoles. If needed, the
service would also be restarted after a configuration change, consoles
were happy and everything was good, well, almost.

Since the service had no way to specify the dependency "ttys are ready",
modesetting could sometimes happen *after* systemd-vconsole-setup had
started, leaving the console in a broken state. So abbradar worked
around that by putting a systemd-udev-settle `After=`.

In the meanwhile, probably realizing their mistake, systemd added a
shiny udev rule to start the systemd-udev-settle at the right time[2].
However, the rule bypassed systemd by directly running the binary
`systemd-udev-settle`, and the service - though still installed - fell
into disuse.

Two years would pass before a good samaritan, seeing the poor jobless
systemd-udev-settle service, decided to give it the coup de grâs[3] by
unlisting it from the installed units.
This, combined with another bug, caused quite a commotion[4] in NixOS;
to see why remember the fact that `WantedBy=` in upstream units doesn't
work[5], so it had to be added manually in cc542110, but while systemd
removed it, the NixOS unit continued to install and restart the service,
making a lot of fuss when switching configuration.

After at least thee different tentative fixes, deedrah realised[6] what
the root cause was and fpletz put the final nail[7] in the coffin of
systemd-udev-settle. The service would never see the light of a boot
again, NixOS would not restart it all the time but thanks to udev
consoles would still get their pretty fonts and playful colors.

The En..

..no, wait! You should ask what came of systemd-udev-settle, first.
And why is the service even around if udev is doing all the work?

Udev-settle, like the deceitful snake that he is, laid hidden for years.
He looks innocuous doesn't it? A little hack. Only until it leaves his
den and a poor user[8] drops dead. Obviously, it serves no purpose, as
the service is not part of the boot process anymore, so let's remove it
for good!

About the service, it may not be useful at boot, but it can be started
to pick up changes in vconsole.conf and set the consoles accordingly.
But wait, this doesn't work anymore: the service is never started at
boot (remember f76d2aa6), so switch-to-configuration.pl will not restart
it. Fortunately it can be repaired: here I install a new unit which
does *nothing* on start, but restarts the real service when reloaded.
This perfectly reproduces the original behavior, hopefully without the
original bugs too.

The End?

[1]: cc54211069
[2]: f6ba8671d8 (diff-84849fddcef81458f69725dc18c6614aade5c4f41a032b6908ebcf1ee6740636)
[3]: 8125e8d38e
[4]: https://web.archive.org/web/20180603130107/https://github.com/NixOS/nixpkgs/issues/22470
[5]: https://github.com/NixOS/nixpkgs/issues/81138
[6]: https://web.archive.org/web/20180603130107/https://github.com/NixOS/nixpkgs/issues/22470#issuecomment-330930456
[7]: f76d2aa6e3
[8]: https://github.com/NixOS/nixpkgs/issues/107341
2021-02-21 10:27:34 +01:00
..
config nixos/console: fix console setting reloading 2021-02-21 10:27:34 +01:00
hardware Merge pull request #111996 from rnhmjoj/i2c 2021-02-06 18:22:34 +01:00
i18n/input-method fcitx5: update doc 2021-01-24 02:10:23 +01:00
installer nixos/tools: generate an xserver config 2021-02-13 18:46:01 -05:00
misc nixos/dysnomia nixos/disnix: Drop modules 2021-01-27 11:27:09 +01:00
profiles qemu-guest: remove security.rngd setting 2021-01-27 18:27:34 +01:00
programs nixos/captive-browser: make it work without a fixed interface 2021-02-12 14:35:51 +08:00
security Merge pull request #108819 from SuperSandro2000/nginx-module 2021-01-30 21:46:35 +01:00
services Merge pull request #108045 from mmilata/moinmoin-module-fix 2021-02-18 16:13:22 +01:00
system nixos/systemd-lib: allow mkIf in unitOption 2021-02-11 22:18:21 +01:00
tasks zfs: disable smartmontools mail functionality 2021-02-06 22:04:00 -08:00
testing nixos/service-runner: fix evaluation 2021-02-05 13:02:56 +01:00
virtualisation nixos/hypervGuest: add Microsoft Synthetic Keyboard driver 2021-02-17 08:01:34 +00:00
module-list.nix Merge pull request #110615 from jansol/pipewire 2021-02-17 07:41:27 +00:00
rename.nix nixos.flashpolicyd: drop 2021-02-08 09:38:48 -08:00