1
0
Fork 1
mirror of https://github.com/NixOS/nixpkgs.git synced 2024-11-18 11:40:45 +00:00
Nix Packages collection
Go to file
Emily 98648422e8 signal-desktop: replace unlicensed Apple emoji
Signal ships the Apple emoji set without a licence via an npm package
and upstream does not seem terribly interested in fixing this; see:

* <https://github.com/signalapp/Signal-Android/issues/5862>
* <https://whispersystems.discoursehosting.net/t/signal-is-likely-violating-apple-license-terms-by-using-apple-emoji-in-the-sticker-creator-and-android-and-desktop-apps/52883>

I don’t want to mark Signal as `lib.licenses.unfree`, so this change
instead replaces the bundled Apple emoji PNGs with ones generated
from our freely‐licensed Noto Color Emoji font.

I chose Noto Color Emoji because it is the best‐maintained FOSS
emoji font, and because Signal Android will also use the Noto emoji
if the “Chats → Keyboard → Use system emoji” setting is
turned on. Therefore, Noto Color Emoji is both within the bounds
of the Signal user experience on other platforms, and more likely
to match the emoji font installed on a NixOS system to boot. I have
verified that Noto Color Emoji covers all the standalone emoji that
the bundled Apple set does, and could not find any emoji sequence
that reliably displayed correctly in Signal before these changes but
did not afterwards. (Though I sure did find a good number of emoji
that displayed weirdly in Signal both before and after.)

Signal will also download and cache large versions of the Apple
emoji from their own update server at runtime. This does not pose
a copyright concern for the Nixpkgs cache, but would result in
inconsistent presentation between small and large emoji. Therefore,
we also point these to our Noto Color Emoji PNGs, and gain a little
privacy in the process.

**No invasive patches are made to the Signal code;** the only
changes are to replace the unlicensed Apple emoji files with our own,
and replace the URL that large versions are fetched from to point
to them. There is no functional change to the application other
than showing different images on the client and not requesting the
jumbomoji pack files from the Signal update server. Ideally we’d
build this package from source and simply omit the problematic files
in the first place, but apparently that’s a little tricky and we
should solve the compliance problem now.

The best solution, of course, would be for Signal to replace their
unlicensed copy of Apple’s emoji with a freely‐licensed set
compatible with their AGPLv3 licence. I may try and raise this
situation again with Signal, although given the past response I am
not optimistic, but I wanted to first address the potential copyright
violation in Nixpkgs as swiftly as possible.

Although the Python script used to copy and rename the Noto PNGs
is very simple, I have extensively documented it to help increase
confidence in it and ease further maintenance. To reflect my
willingness to keep this change maintained and take responsibility
for it, I have added myself to the package maintainer list.

These changes actually result in the uncompressed size of the resulting
package decreasing from 450 MiB to 435 MiB; as Signal would ordinarily
download and cache up to 27 MiB of jumbomoji sheets from their servers
during use, the effective disk space savings are likely to be higher.

Thanks to @mjm for helping test this.
2024-08-27 06:39:28 +01:00
.github CODEOWNERS: add myself to ACME 2024-08-22 19:53:50 +01:00
ci ci: Update pinned Nixpkgs 2024-08-22 16:42:30 +02:00
doc doc: add documentation for pkgs.{substitute,substituteAll,substituteAllFiles} 2024-08-21 20:11:02 +02:00
lib Merge pull request #333915 from jopejoe1/license 2024-08-24 12:39:30 +02:00
maintainers Merge pull request #336649 from joelkoen/maintainer 2024-08-24 11:05:22 -06:00
nixos Merge pull request #336836 from oddlama/feat-update-kanidm-provision 2024-08-24 08:58:35 -04:00
pkgs signal-desktop: replace unlicensed Apple emoji 2024-08-27 06:39:28 +01:00
.editorconfig .editorconfig: accept package.json indent as is 2024-07-29 19:24:33 +02:00
.git-blame-ignore-revs nrr: update .git-blame-ignore-revs 2024-08-18 18:10:07 +08:00
.gitattributes
.gitignore Ignore Direnv files 2024-07-23 17:06:34 +07:00
.mailmap maintainers: update goatastronaut0212's email 2024-08-15 09:11:25 +07:00
.version
CONTRIBUTING.md CONTRIBUTING.md: Mention nixfmt instead of manual formatting rules 2024-07-26 00:37:42 +02:00
COPYING
default.nix
flake.nix flake.nix: add pinned devshell 2024-08-09 19:25:59 -07:00
README.md
shell.nix root: add nixpkgs-review to shell.nix 2024-07-13 16:04:07 +02:00

NixOS logo

Contributors badge Open Collective supporters

Nixpkgs is a collection of over 100,000 software packages that can be installed with the Nix package manager. It also implements NixOS, a purely-functional Linux distribution.

Manuals

  • NixOS Manual - how to install, configure, and maintain a purely-functional Linux distribution
  • Nixpkgs Manual - contributing to Nixpkgs and using programming-language-specific Nix expressions
  • Nix Package Manager Manual - how to write Nix expressions (programs), and how to use Nix command line tools

Community

Other Project Repositories

The sources of all official Nix-related projects are in the NixOS organization on GitHub. Here are some of the main ones:

  • Nix - the purely functional package manager
  • NixOps - the tool to remotely deploy NixOS machines
  • nixos-hardware - NixOS profiles to optimize settings for different hardware
  • Nix RFCs - the formal process for making substantial changes to the community
  • NixOS homepage - the NixOS.org website
  • hydra - our continuous integration system
  • NixOS Artwork - NixOS artwork

Continuous Integration and Distribution

Nixpkgs and NixOS are built and tested by our continuous integration system, Hydra.

Artifacts successfully built with Hydra are published to cache at https://cache.nixos.org/. When successful build and test criteria are met, the Nixpkgs expressions are distributed via Nix channels.

Contributing

Nixpkgs is among the most active projects on GitHub. While thousands of open issues and pull requests might seem a lot at first, it helps consider it in the context of the scope of the project. Nixpkgs describes how to build tens of thousands of pieces of software and implements a Linux distribution. The GitHub Insights page gives a sense of the project activity.

Community contributions are always welcome through GitHub Issues and Pull Requests.

For more information about contributing to the project, please visit the contributing page.

Donations

The infrastructure for NixOS and related projects is maintained by a nonprofit organization, the NixOS Foundation. To ensure the continuity and expansion of the NixOS infrastructure, we are looking for donations to our organization.

You can donate to the NixOS foundation through SEPA bank transfers or by using Open Collective:

License

Nixpkgs is licensed under the MIT License.

Note: MIT license does not apply to the packages built by Nixpkgs, merely to the files in this repository (the Nix expressions, build scripts, NixOS modules, etc.). It also might not apply to patches included in Nixpkgs, which may be derivative works of the packages to which they apply. The aforementioned artifacts are all covered by the licenses of the respective packages.