1
0
Fork 1
mirror of https://github.com/NixOS/nixpkgs.git synced 2024-11-26 23:52:33 +00:00
nixpkgs/pkgs/tools
Bjørn Forsman 581226cfb4 nixos/bcache: /bin/sh -> ${bash}/bin/sh
Or else `services.udev.packages = [ bcache-tools ]` cannot be used.

To not break bcache in the initrd I'm modifying this in stage-1.nix:

  -  --replace /bin/sh ${extraUtils}/bin/sh
  +  --replace ${bash}/bin/sh ${extraUtils}/bin/sh

Reasoning behind that change:

* If not modifying the /bin/sh pattern in any way, it will also match
  ${bash}/bin/sh, creating a broken path like
  /nix/store/HASH-bash/nix/store/HASH-bash/bin/sh in the udev rule file.

* The addition of /bin/sh was done in 775f381a9e
  ("stage-1: add bcache support"). It seems somewhat plausible that
  no new users have appeared since then and we can take this opportunity
  to back out of this change without much fear of regressions.

  If there _are_ regressions, they should be in the form of build time
  errors, not runtime (boot), due to how the udev rule output is checked
  for invalid path references. So low risk, IMHO.

* An alternative approach could be to copy the /bin/sh substitute rule
  over to the non-initrd udev rules implementation in NixOS, but I think
  this way is better:
  - The rules file comes with a working path out of the box.
  - We can use more precise pattern matching when modifying the udev
    rules for the initrd.
2017-06-10 17:10:49 +02:00
..
admin daemontools: fix build 2017-05-31 23:57:15 +01:00
archivers zpaqd: Modernize derivation 2017-05-22 18:52:50 -04:00
audio pnmixer: 0.7.1-rc1 -> 0.7.1 2017-05-26 15:32:53 +02:00
backup restic: 0.6.0 -> 0.6.1 2017-06-01 17:41:56 +02:00
bluetooth blueman: wrap binaries in libexec 2017-06-01 14:30:40 +03:00
bootloaders/refind
cd-dvd unetbootin: set QT_X11_NO_MITSHM=1 2017-05-20 14:42:32 -04:00
compression mozlz4a: init at 2015-07-24 2017-05-21 00:21:47 +02:00
filesystems nixos/bcache: /bin/sh -> ${bash}/bin/sh 2017-06-10 17:10:49 +02:00
graphics maim: 3.4.47 -> 5.4.63 2017-06-08 01:51:34 +02:00
inputmethods ibus-m17n: fix homepage URL. 2017-05-27 22:39:16 -04:00
misc Merge pull request #26296 from gnidorah/master3 2017-06-10 11:00:53 +01:00
nagstamon nagstamon: init at 2.0.1 2017-06-01 19:32:06 +02:00
networking Merge pull request #26239 from jensbin/networkmanager-dmenu_20170528 2017-06-03 13:07:06 +01:00
package-management nixUnstable: 1.12pre5350_7689181e -> 1.12pre5413_b4b1f452 2017-06-06 15:06:42 +02:00
security Merge pull request #26495 from makefu/pkgs/metasploit/update 2017-06-09 22:39:07 +01:00
system fio: 2.19 -> 2.20 2017-06-08 23:13:06 +03:00
text Merge pull request #26423 from sjagoe/fix-grin-dependencies 2017-06-10 12:02:18 +01:00
typesetting halibut: 1.1 -> 1.2 2017-05-29 09:58:10 +02:00
video
virtualization cloud-init: remove argparse from requirements.txt 2017-06-05 21:44:05 +02:00
X11 fix #25511 2017-06-05 23:37:53 +00:00