1
0
Fork 1
mirror of https://github.com/NixOS/nixpkgs.git synced 2024-09-11 15:08:33 +01:00
nixpkgs/nixos/modules
Bjørn Forsman 581226cfb4 nixos/bcache: /bin/sh -> ${bash}/bin/sh
Or else `services.udev.packages = [ bcache-tools ]` cannot be used.

To not break bcache in the initrd I'm modifying this in stage-1.nix:

  -  --replace /bin/sh ${extraUtils}/bin/sh
  +  --replace ${bash}/bin/sh ${extraUtils}/bin/sh

Reasoning behind that change:

* If not modifying the /bin/sh pattern in any way, it will also match
  ${bash}/bin/sh, creating a broken path like
  /nix/store/HASH-bash/nix/store/HASH-bash/bin/sh in the udev rule file.

* The addition of /bin/sh was done in 775f381a9e
  ("stage-1: add bcache support"). It seems somewhat plausible that
  no new users have appeared since then and we can take this opportunity
  to back out of this change without much fear of regressions.

  If there _are_ regressions, they should be in the form of build time
  errors, not runtime (boot), due to how the udev rule output is checked
  for invalid path references. So low risk, IMHO.

* An alternative approach could be to copy the /bin/sh substitute rule
  over to the non-initrd udev rules implementation in NixOS, but I think
  this way is better:
  - The rules file comes with a working path out of the box.
  - We can use more precise pattern matching when modifying the udev
    rules for the initrd.
2017-06-10 17:10:49 +02:00
..
config systemd-resolved: fix case when dnsmasq is used as local resolver 2017-05-31 23:30:35 +01:00
hardware nvidia module: link proper output as OpenGL drivers 2017-05-31 16:30:21 +03:00
i18n/input-method Remove top-level kde5 attribute 2017-02-27 11:49:10 -06:00
installer sd-image-*.nix: Drop minimal profile 2017-05-14 23:52:47 +03:00
misc Merge pull request #26191 from romildo/fix.mlocate 2017-06-10 11:56:26 +01:00
profiles hardware.enableRedistributableFirmware: fix spelling error 2017-05-09 20:13:15 +01:00
programs programs.zsh.syntaxHighlighting: Fix default value for patterns 2017-06-04 15:30:35 -04:00
security nixos/acme: improve documentation 2017-06-09 19:35:17 +02:00
service-managers Simple proof of concept for how to do other types of services 2017-05-26 18:14:31 -04:00
services bind service: add listen-on options (#26430) 2017-06-10 12:19:07 +02:00
system nixos/bcache: /bin/sh -> ${bash}/bin/sh 2017-06-10 17:10:49 +02:00
tasks typo: powerManagment -> powerManagement (#25813) 2017-05-16 18:22:44 +02:00
testing kdm: drop service 2017-02-11 13:55:09 -05:00
virtualisation lxd: 2.0.2 -> 2.12 (#25685) 2017-05-24 19:29:38 +01:00
module-list.nix resilio service: replaces btsync service, which is no longer supported upstream. 2017-06-02 21:24:49 +01:00
rename.nix programs.zsh: rename oh-my-zsh to ohMyZsh 2017-05-25 10:51:26 +02:00