mirror of
https://github.com/NixOS/nixpkgs.git
synced 2024-12-25 03:17:13 +00:00
e0464e4788
In preparation for the deprecation of `stdenv.isX`. These shorthands are not conducive to cross-compilation because they hide the platforms. Darwin might get cross-compilation for which the continued usage of `stdenv.isDarwin` will get in the way One example of why this is bad and especially affects compiler packages https://www.github.com/NixOS/nixpkgs/pull/343059 There are too many files to go through manually but a treewide should get users thinking when they see a `hostPlatform.isX` in a place where it doesn't make sense. ``` fd --type f "\.nix" | xargs sd --fixed-strings "stdenv.is" "stdenv.hostPlatform.is" fd --type f "\.nix" | xargs sd --fixed-strings "stdenv'.is" "stdenv'.hostPlatform.is" fd --type f "\.nix" | xargs sd --fixed-strings "clangStdenv.is" "clangStdenv.hostPlatform.is" fd --type f "\.nix" | xargs sd --fixed-strings "gccStdenv.is" "gccStdenv.hostPlatform.is" fd --type f "\.nix" | xargs sd --fixed-strings "stdenvNoCC.is" "stdenvNoCC.hostPlatform.is" fd --type f "\.nix" | xargs sd --fixed-strings "inherit (stdenv) is" "inherit (stdenv.hostPlatform) is" fd --type f "\.nix" | xargs sd --fixed-strings "buildStdenv.is" "buildStdenv.hostPlatform.is" fd --type f "\.nix" | xargs sd --fixed-strings "effectiveStdenv.is" "effectiveStdenv.hostPlatform.is" fd --type f "\.nix" | xargs sd --fixed-strings "originalStdenv.is" "originalStdenv.hostPlatform.is" ```
86 lines
2.6 KiB
Nix
86 lines
2.6 KiB
Nix
{ lib, stdenv, pkgsHostHost
|
|
, file, curl, pkg-config, python3, openssl, cmake, zlib
|
|
, installShellFiles, makeWrapper, rustPlatform, rustc
|
|
, CoreFoundation, Security
|
|
, auditable ? !cargo-auditable.meta.broken
|
|
, cargo-auditable
|
|
, pkgsBuildBuild
|
|
}:
|
|
|
|
rustPlatform.buildRustPackage.override {
|
|
cargo-auditable = cargo-auditable.bootstrap;
|
|
} ({
|
|
pname = "cargo";
|
|
inherit (rustc.unwrapped) version src;
|
|
|
|
# the rust source tarball already has all the dependencies vendored, no need to fetch them again
|
|
cargoVendorDir = "vendor";
|
|
buildAndTestSubdir = "src/tools/cargo";
|
|
|
|
inherit auditable;
|
|
|
|
passthru = {
|
|
rustc = rustc;
|
|
inherit (rustc.unwrapped) tests;
|
|
};
|
|
|
|
# changes hash of vendor directory otherwise
|
|
dontUpdateAutotoolsGnuConfigScripts = true;
|
|
|
|
nativeBuildInputs = [
|
|
pkg-config cmake installShellFiles makeWrapper
|
|
(lib.getDev pkgsHostHost.curl)
|
|
zlib
|
|
];
|
|
buildInputs = [ file curl python3 openssl zlib ]
|
|
++ lib.optionals stdenv.hostPlatform.isDarwin [ CoreFoundation Security ];
|
|
|
|
# cargo uses git-rs which is made for a version of libgit2 from recent master that
|
|
# is not compatible with the current version in nixpkgs.
|
|
#LIBGIT2_SYS_USE_PKG_CONFIG = 1;
|
|
|
|
# fixes: the cargo feature `edition` requires a nightly version of Cargo, but this is the `stable` channel
|
|
RUSTC_BOOTSTRAP = 1;
|
|
|
|
postInstall = ''
|
|
wrapProgram "$out/bin/cargo" --suffix PATH : "${rustc}/bin"
|
|
|
|
installManPage src/tools/cargo/src/etc/man/*
|
|
|
|
installShellCompletion --bash --name cargo \
|
|
src/tools/cargo/src/etc/cargo.bashcomp.sh
|
|
|
|
installShellCompletion --zsh src/tools/cargo/src/etc/_cargo
|
|
'';
|
|
|
|
checkPhase = ''
|
|
# Disable cross compilation tests
|
|
export CFG_DISABLE_CROSS_TESTS=1
|
|
cargo test
|
|
'';
|
|
|
|
# Disable check phase as there are failures (4 tests fail)
|
|
doCheck = false;
|
|
|
|
doInstallCheck = !stdenv.hostPlatform.isStatic && stdenv.hostPlatform.isElf;
|
|
installCheckPhase = ''
|
|
runHook preInstallCheck
|
|
readelf -a $out/bin/.cargo-wrapped | grep -F 'Shared library: [libcurl.so'
|
|
runHook postInstallCheck
|
|
'';
|
|
|
|
meta = with lib; {
|
|
homepage = "https://crates.io";
|
|
description = "Downloads your Rust project's dependencies and builds your project";
|
|
mainProgram = "cargo";
|
|
maintainers = teams.rust.members;
|
|
license = [ licenses.mit licenses.asl20 ];
|
|
platforms = platforms.unix;
|
|
# https://github.com/alexcrichton/nghttp2-rs/issues/2
|
|
broken = stdenv.hostPlatform.isx86 && stdenv.buildPlatform != stdenv.hostPlatform;
|
|
};
|
|
}
|
|
// lib.optionalAttrs (stdenv.buildPlatform.rust.rustcTarget != stdenv.hostPlatform.rust.rustcTarget) {
|
|
HOST_PKG_CONFIG_PATH="${pkgsBuildBuild.pkg-config}/bin/pkg-config";
|
|
})
|