mirror of
https://github.com/NixOS/nixpkgs.git
synced 2024-11-22 21:50:55 +00:00
45f486f096
This reverts commit 4c751ced37
.
This does not fix the issue as /run is now mounted with nosuid.
219 lines
7 KiB
Nix
219 lines
7 KiB
Nix
{ config, lib, pkgs, ... }:
|
|
let
|
|
|
|
inherit (config.security) wrapperDir wrappers;
|
|
|
|
parentWrapperDir = dirOf wrapperDir;
|
|
|
|
programs =
|
|
(lib.mapAttrsToList
|
|
(n: v: (if v ? "program" then v else v // {program=n;}))
|
|
wrappers);
|
|
|
|
securityWrapper = pkgs.stdenv.mkDerivation {
|
|
name = "security-wrapper";
|
|
phases = [ "installPhase" "fixupPhase" ];
|
|
buildInputs = [ pkgs.libcap pkgs.libcap_ng pkgs.linuxHeaders ];
|
|
hardeningEnable = [ "pie" ];
|
|
installPhase = ''
|
|
mkdir -p $out/bin
|
|
gcc -Wall -O2 -DWRAPPER_DIR=\"${parentWrapperDir}\" \
|
|
-lcap-ng -lcap ${./wrapper.c} -o $out/bin/security-wrapper
|
|
'';
|
|
};
|
|
|
|
###### Activation script for the setcap wrappers
|
|
mkSetcapProgram =
|
|
{ program
|
|
, capabilities
|
|
, source
|
|
, owner ? "nobody"
|
|
, group ? "nogroup"
|
|
, permissions ? "u+rx,g+x,o+x"
|
|
, ...
|
|
}:
|
|
assert (lib.versionAtLeast (lib.getVersion config.boot.kernelPackages.kernel) "4.3");
|
|
''
|
|
cp ${securityWrapper}/bin/security-wrapper $wrapperDir/${program}
|
|
echo -n "${source}" > $wrapperDir/${program}.real
|
|
|
|
# Prevent races
|
|
chmod 0000 $wrapperDir/${program}
|
|
chown ${owner}.${group} $wrapperDir/${program}
|
|
|
|
# Set desired capabilities on the file plus cap_setpcap so
|
|
# the wrapper program can elevate the capabilities set on
|
|
# its file into the Ambient set.
|
|
${pkgs.libcap.out}/bin/setcap "cap_setpcap,${capabilities}" $wrapperDir/${program}
|
|
|
|
# Set the executable bit
|
|
chmod ${permissions} $wrapperDir/${program}
|
|
'';
|
|
|
|
###### Activation script for the setuid wrappers
|
|
mkSetuidProgram =
|
|
{ program
|
|
, source
|
|
, owner ? "nobody"
|
|
, group ? "nogroup"
|
|
, setuid ? false
|
|
, setgid ? false
|
|
, permissions ? "u+rx,g+x,o+x"
|
|
, ...
|
|
}:
|
|
''
|
|
cp ${securityWrapper}/bin/security-wrapper $wrapperDir/${program}
|
|
echo -n "${source}" > $wrapperDir/${program}.real
|
|
|
|
# Prevent races
|
|
chmod 0000 $wrapperDir/${program}
|
|
chown ${owner}.${group} $wrapperDir/${program}
|
|
|
|
chmod "u${if setuid then "+" else "-"}s,g${if setgid then "+" else "-"}s,${permissions}" $wrapperDir/${program}
|
|
'';
|
|
|
|
mkWrappedPrograms =
|
|
builtins.map
|
|
(s: if (s ? "capabilities")
|
|
then mkSetcapProgram
|
|
({ owner = "root";
|
|
group = "root";
|
|
} // s)
|
|
else if
|
|
(s ? "setuid" && s.setuid == true) ||
|
|
(s ? "setguid" && s.setguid == true) ||
|
|
(s ? "permissions")
|
|
then mkSetuidProgram s
|
|
else mkSetuidProgram
|
|
({ owner = "root";
|
|
group = "root";
|
|
setuid = true;
|
|
setgid = false;
|
|
permissions = "u+rx,g+x,o+x";
|
|
} // s)
|
|
) programs;
|
|
in
|
|
{
|
|
|
|
###### interface
|
|
|
|
options = {
|
|
security.wrappers = lib.mkOption {
|
|
type = lib.types.attrs;
|
|
default = {};
|
|
example = lib.literalExample
|
|
''
|
|
{ sendmail.source = "/nix/store/.../bin/sendmail";
|
|
ping = {
|
|
source = "${pkgs.iputils.out}/bin/ping";
|
|
owner = "nobody";
|
|
group = "nogroup";
|
|
capabilities = "cap_net_raw+ep";
|
|
};
|
|
}
|
|
'';
|
|
description = ''
|
|
This option allows the ownership and permissions on the setuid
|
|
wrappers for specific programs to be overridden from the
|
|
default (setuid root, but not setgid root).
|
|
|
|
<note>
|
|
<para>The sub-attribute <literal>source</literal> is mandatory,
|
|
it must be the absolute path to the program to be wrapped.
|
|
</para>
|
|
|
|
<para>The sub-attribute <literal>program</literal> is optional and
|
|
can give the wrapper program a new name. The default name is the same
|
|
as the attribute name itself.</para>
|
|
|
|
<para>Additionally, this option can set capabilities on a
|
|
wrapper program that propagates those capabilities down to the
|
|
wrapped, real program.</para>
|
|
|
|
<para>NOTE: cap_setpcap, which is required for the wrapper
|
|
program to be able to raise caps into the Ambient set is NOT
|
|
raised to the Ambient set so that the real program cannot
|
|
modify its own capabilities!! This may be too restrictive for
|
|
cases in which the real program needs cap_setpcap but it at
|
|
least leans on the side security paranoid vs. too
|
|
relaxed.</para>
|
|
</note>
|
|
'';
|
|
};
|
|
|
|
security.wrapperDir = lib.mkOption {
|
|
type = lib.types.path;
|
|
default = "/run/wrappers/bin";
|
|
internal = true;
|
|
description = ''
|
|
This option defines the path to the wrapper programs. It
|
|
should not be overriden.
|
|
'';
|
|
};
|
|
};
|
|
|
|
###### implementation
|
|
config = {
|
|
|
|
security.wrappers.fusermount.source = "${pkgs.fuse}/bin/fusermount";
|
|
|
|
boot.specialFileSystems.${parentWrapperDir} = {
|
|
fsType = "tmpfs";
|
|
options = [ "nodev" ];
|
|
};
|
|
|
|
# Make sure our wrapperDir exports to the PATH env variable when
|
|
# initializing the shell
|
|
environment.extraInit = ''
|
|
# Wrappers override other bin directories.
|
|
export PATH="${wrapperDir}:$PATH"
|
|
'';
|
|
|
|
###### setcap activation script
|
|
system.activationScripts.wrappers =
|
|
lib.stringAfter [ "users" ]
|
|
''
|
|
# Look in the system path and in the default profile for
|
|
# programs to be wrapped.
|
|
WRAPPER_PATH=${config.system.path}/bin:${config.system.path}/sbin
|
|
|
|
# Remove the old /var/setuid-wrappers path from the system...
|
|
#
|
|
# TODO: this is only necessary for ugprades 16.09 => 17.x;
|
|
# this conditional removal block needs to be removed after
|
|
# the release.
|
|
if [ -d /var/setuid-wrappers ]; then
|
|
rm -rf /var/setuid-wrappers
|
|
fi
|
|
|
|
# Remove the old /run/setuid-wrappers-dir path from the
|
|
# system as well...
|
|
#
|
|
# TODO: this is only necessary for ugprades 16.09 => 17.x;
|
|
# this conditional removal block needs to be removed after
|
|
# the release.
|
|
if [ -d /run/setuid-wrapper-dirs ]; then
|
|
rm -rf /run/setuid-wrapper-dirs
|
|
fi
|
|
|
|
# We want to place the tmpdirs for the wrappers to the parent dir.
|
|
wrapperDir=$(mktemp --directory --tmpdir="${parentWrapperDir}" wrappers.XXXXXXXXXX)
|
|
chmod a+rx $wrapperDir
|
|
|
|
${lib.concatStringsSep "\n" mkWrappedPrograms}
|
|
|
|
if [ -L ${wrapperDir} ]; then
|
|
# Atomically replace the symlink
|
|
# See https://axialcorps.com/2013/07/03/atomically-replacing-files-and-directories/
|
|
old=$(readlink -f ${wrapperDir})
|
|
ln --symbolic --force --no-dereference $wrapperDir ${wrapperDir}-tmp
|
|
mv --no-target-directory ${wrapperDir}-tmp ${wrapperDir}
|
|
rm --force --recursive $old
|
|
else
|
|
# For initial setup
|
|
ln --symbolic $wrapperDir ${wrapperDir}
|
|
fi
|
|
'';
|
|
};
|
|
}
|