mirrors/nixpkgs
1
0
Fork 1
mirror of https://github.com/NixOS/nixpkgs.git synced 2024-09-11 15:08:33 +01:00
Code Issues Wiki Activity
nixpkgs/pkgs/test
History
Silvan Mosberger 92284634ec tests.nixpkgs-check-by-name: Test against sbcl-like regression 
This adds a test to check that a commit like 0a3dab4af3 would fail CI

After doing some improvements to the `pkgs/by-name` check I discovered
that sbcl shouldn't have been allowed in `pkgs/by-name` after all as is.

Specifically, the requirement is that if `pkgs/by-name/sb/sbcl` exists,
the definition of the `sbcl` attribute must look like

    sbcl = callPackage ../by-name/sb/sbcl/package.nix { ... };

However it currently is an alias like

    sbcl = sbcl_2_4_1;

This wasn't detected before because `sbcl_2_4_1` was semantically
defined using `callPackage`:

    sbcl_2_4_1 = wrapLisp {
      pkg = callPackage ../development/compilers/sbcl { version = "2.4.1"; };
      faslExt = "fasl";
      flags = [ "--dynamic-space-size" "3000" ];
    };

However this doesn't syntactically match what is required.

In https://github.com/NixOS/nixpkgs/pull/285089 I introduced syntactic
checks for exactly this, but they were only used for packages not
already in `pkgs/by-name`.

Only now that I'm doing the refactoring to also use this check for
`pkgs/by-name` packages this problem is noticed.

While introducing this new check is technically an increase in
strictness, and therefore would justify adding a new ratchet, I consider
this case to be rare enough that we don't need to do that.

This commit introduces a test to prevent such regressions in the
future

Moving sbcl back out of `pkgs/by-name` will be done when the pinned CI is updated
2024-02-08 02:38:11 +01:00
..
auto-patchelf-hook Test __structuredAttrs support in autoPatchelf 2023-12-21 15:42:20 +01:00
buildFHSEnv tests.buildFHSEnv.libtinfo: fix by using overriden ncurses 2024-01-16 10:19:46 +02:00
cc-wrapper tests.cc-wrapper: add atomics test 2023-11-16 00:23:56 +02:00
checkpointBuild Merge pull request #279487 from bryango/checkpoint-build-polish 2024-01-09 22:30:22 +01:00
coq
cross tests.cross.sanity: fix eval by fixing qt5.qutebrowser reference 2024-01-25 10:51:29 +00:00
cuda cudaPackages.cuda{,-library}-samples: move to cuda-modules/ 2024-01-12 20:24:50 +00:00
cue
dhall
dotnet
haskell haskellPackages: Fix eval errors 2024-01-01 19:16:21 +01:00
hooks
install-shell-files
ld-library-path
macos-sierra-shared
make-binary-wrapper
make-hardcode-gsettings-patch makeHardcodeGsettingsPatch: Support applying patches 2023-11-21 08:42:47 +01:00
make-wrapper
nixos-functions
nixpkgs-check-by-name tests.nixpkgs-check-by-name: Test against sbcl-like regression 2024-02-08 02:38:11 +01:00
php
release pkgs/release: don't interpolate store paths unnecessarily 2024-01-12 10:27:19 +03:00
simple
stdenv
stdenv-inputs
texlive texlive: 2022-final -> 2023.20240114 2024-01-27 09:32:22 +00:00
top-level
vim
config.nix
default.nix Merge pull request #279844 from doronbehar/tests/buildFHSEnv 2024-01-31 16:09:16 +01:00
kernel.nix
overriding.nix