1
0
Fork 1
mirror of https://github.com/NixOS/nixpkgs.git synced 2024-09-11 15:08:33 +01:00
nixpkgs/pkgs
Bjørn Forsman 3227c1d215 ncurses: fix includedir setting
${out} in configureFlags isn't expanded, so ncursesw5-config ends up
expanding ${out} at *runtime*. Here is the relevant ncursesw5-config
snippet showing how includedir gets its value at runtime.

  bindir="${exec_prefix}/bin"
  includedir="${out}/include"
  libdir="${exec_prefix}/lib"
  datadir="${prefix}/share"
  mandir="${prefix}/man"

When running in a plain shell you get this:
  $ ncursesw5-config --cflags
  -I/include/ncursesw -I/include

And when run in a nix-build shell for e.g. gpsd:
  $ ncursesw5-config --cflags
  -I/nix/store/HASH-gpsd-3.10/include/ncursesw -I/nix/store/HASH-gpsd-3.10/include

This is clearly wrong.

Q: How come this has gone undetected for years?
A: It seems few packages use ncursesw5-config to get the compiler
flags. For example, our python curses module builds its own compiler
flags.

Fix this by moving the --includedir setting to preConfigure where shell
variables are expanded.
2013-12-10 19:47:52 +01:00
..
applications Merge remote-tracking branch 'origin/master' into stdenv-updates. 2013-12-10 00:25:54 +01:00
build-support Merge remote-tracking branch 'origin/master' into stdenv-updates. 2013-12-04 18:33:52 +01:00
data shared_mime_info: update from 1.1 to 1.2 2013-12-04 06:53:44 +02:00
desktops KDE-4.10: Kopete: fix build against giflib5 2013-12-08 12:04:02 +02:00
development ncurses: fix includedir setting 2013-12-10 19:47:52 +01:00
games Merge remote-tracking branch 'origin/master' into stdenv-updates. 2013-12-10 00:25:54 +01:00
misc Merge remote-tracking branch 'origin/master' into stdenv-updates. 2013-12-10 00:25:54 +01:00
os-specific Linux 3.12.4 2013-12-09 12:01:37 -05:00
servers Merge remote-tracking branch 'origin/master' into stdenv-updates. 2013-12-10 00:25:54 +01:00
shells Merge remote-tracking branch 'origin/master' into stdenv-updates. 2013-12-04 18:33:52 +01:00
stdenv stdenv/patchShebangs: fix shebang check 2013-12-07 21:13:06 +01:00
test
tools Merge remote-tracking branch 'origin/master' into stdenv-updates. 2013-12-10 00:25:54 +01:00
top-level Merge remote-tracking branch 'origin/master' into stdenv-updates. 2013-12-10 00:25:54 +01:00