1
0
Fork 1
mirror of https://github.com/NixOS/nixpkgs.git synced 2024-11-22 13:41:26 +00:00
nixpkgs/pkgs/servers/mail
Léo Gaspard 02e1f00ffd
dovecot, opensmtpd: add link to test in meta.tests
Rationale
---------

Currently, tests are hard to discover. For instance, someone updating
`dovecot` might not notice that the interaction of `dovecot` with
`opensmtpd` is handled in the `opensmtpd.nix` test.

And even for someone updating `opensmtpd`, it requires manual work to go
check in `nixos/tests` whether there is actually a test, especially
given not so many packages in `nixpkgs` have tests and this is thus most
of the time useless.

Finally, for the reviewer, it is much easier to check that the “Tested
via one or more NixOS test(s)” has been checked if the file modified
already includes the list of relevant tests.

Implementation
--------------

Currently, this commit only adds the metadata in the package. Each
element of the `meta.tests` attribute is a derivation that, when it
builds successfully, means the test has passed (ie. following the same
convention as NixOS tests).

Future Work
-----------

In the future, the tools could be made aware of this `meta.tests`
attribute, and for instance a `--with-tests` could be added to
`nix-build` so that it also builds all the tests. Or a `--without-tests`
to build without all the tests. @Profpatsch described in his NixCon talk
such systems.

Another thing that would help in the future would be the possibility to
reasonably easily have cross-derivation nix tests without the whole
NixOS VM stack. @7c6f434c already proposed such a system.

This RFC currently handles none of these concerns. Only the addition of
`meta.tests` as metadata to be used by maintainers to remember to run
relevant tests.
2018-10-30 21:31:39 +09:00
..
archiveopteryx archiveopteryx: fix build w/gcc7 2018-03-17 18:46:45 +01:00
clamsmtp clamsmtp: fix build after linuxHeaders update to 4.15 2018-03-05 10:27:43 +01:00
dkimproxy treewide: fix build with disallowed aliases (#43872) 2018-07-21 22:03:24 -04:00
dovecot dovecot, opensmtpd: add link to test in meta.tests 2018-10-30 21:31:39 +09:00
dspam treewide: fix build with disallowed aliases (#43872) 2018-07-21 22:03:24 -04:00
exim exim: enable LMTP support 2018-09-17 22:01:11 +02:00
freepops
mailhog
mailman mailman: 2.1.24 -> 2.1.29 2018-10-14 05:09:52 -07:00
mlmmj pkgs/*: remove unreferenced function arguments 2018-07-21 02:48:04 +00:00
nullmailer nullmailer: 2.1 -> 2.2 2018-10-26 23:21:53 -07:00
opensmtpd dovecot, opensmtpd: add link to test in meta.tests 2018-10-30 21:31:39 +09:00
petidomo treewide: Make configureFlags lists 2018-08-03 17:06:03 -04:00
popa3d
postfix Merge staging-next into staging 2018-10-17 08:36:28 +02:00
postgrey treewide: http -> https sources (#42676) 2018-06-28 20:43:35 +02:00
postsrsd
pypolicyd-spf pypolicyd-spf: move to all-packages 2018-02-25 22:24:09 +03:00
rmilter
rspamd rspamd: 1.8.0 -> 1.8.1 2018-10-26 02:30:37 -07:00
spamassassin buildPerlPackage -> perlPackages.buildPerlPackage 2018-10-14 09:10:41 +02:00