1
0
Fork 1
mirror of https://github.com/NixOS/nixpkgs.git synced 2024-11-23 22:20:51 +00:00
Commit graph

17 commits

Author SHA1 Message Date
Maxime Dénès 9ca1b56683
pr template: make values of platform field less ambiguous 2017-10-09 12:53:09 +02:00
Piotr Bogdan e221d945ad pr template: make formatting consistent 2017-09-03 19:57:18 +01:00
Linus Heckemann 02d168e130 Pull request template: comment out instructions 2017-08-12 15:17:39 +01:00
Yegor Timoshenko 72239c3a22 PULL_REQUEST_TEMPLATE.md: mereley -> merely 2017-07-28 23:38:25 +00:00
Frederik Rietdijk 138eba0bff Pull request template: clarify the purpose of the template 2017-07-22 18:05:16 +02:00
aszlig fa6fd34fcc
github/pr-template: Add note about NixOS tests
On several occasions I've seen people bumping packages which have NixOS
tests but without actually running them.

While this probably won't prevent such occasions entirely, at least it
serves as an additional checklist item so contributors don't forget
about these tests.

Signed-off-by: aszlig <aszlig@redmoonstudios.org>
2017-06-23 05:33:06 +02:00
Ignat Loskutov d91eba4ec3 Update PULL_REQUEST_TEMPLATE.md
Follow the rebranding of OS X into macOS
2016-11-04 18:49:40 +03:00
Rushmore Mushambi 0192777972 PULL_REQUEST_TEMPLATE: rename chroot to sandbox
See b39622a487
2016-09-02 21:41:43 +02:00
Vladimír Čunát 156105c489 PR template: go back to old option name for now
The old one works on all nix(os) versions, whereas the new one doesn't
work e.g. on default 16.03 setting. Discussed on #15112.
2016-06-29 21:44:05 +02:00
Daniel Peebles 0bd54a6d5d Update PR template with motivation for changes
I'm seeing a lot of PRs that only include the checklist, when the main thing I care about when I'm reviewing a PR is what the author was thinking when they decided to make the change.
2016-05-24 07:59:46 -04:00
Vladimír Čunát 4c10d404e7 github PR template: reformulate the sandboxing help
It's been reported that when running through nix daemon,
sandboxing can't be turned on by passing `--option` (silently ignored),
so let's not suggest that way.
https://github.com/NixOS/nixpkgs/issues/14866#issuecomment-214619909
2016-04-26 09:18:15 +02:00
Vladimír Čunát 7cf8daa2bb nixos: rename chroot* to sandbox*
On Nix side this was done months ago:
https://github.com/NixOS/nix/pull/682
2016-04-25 11:04:08 +02:00
zimbatm 8706726d59 Simplify contributing
* Highlight the top mistakes directly in CONTRIBUTING.md
* Remove unecessary cruft from the PR template
2016-04-09 17:59:35 +01:00
Nathan Zadoks d0b8080062 .github/PULL_REQUEST_TEMPLATE.md: use individual checkboxes for tested OSes 2016-03-16 09:46:05 +01:00
Domen Kožar 2af46e4393 PULL_REQUEST_TEMPLATE: fix issues raised in 3c84ae406 2016-02-28 09:26:28 +00:00
Domen Kožar 3c84ae406d PULL_REQUEST_TEMPLATE.md: clarify a few things 2016-02-28 08:50:33 +00:00
Arseniy Seroka ac9ab2c3f5 PULL_REQUEST_TEMPLATE: init 2016-02-22 13:45:56 +03:00