@the-kenny did a good job in the past and is set as maintainer in many package,
however since 2017-2018 he stopped contributing. To create less confusion
in pull requests when people try to request his feedback, I removed him as
maintainer from all packages.
Whenever we create scripts that are installed to $out, we must use runtimeShell
in order to get the shell that can be executed on the machine we create the
package for. This is relevant for cross-compiling. The only use case for
stdenv.shell are scripts that are executed as part of the build system.
Usages in checkPhase are borderline however to decrease the likelyhood
of people copying the wrong examples, I decided to use runtimeShell as well.
Semi-automatic update generated by https://github.com/ryantm/nixpkgs-update tools.
This update was made based on information from https://repology.org/metapackage/openttd/versions.
These checks were done:
- built on NixOS
- ran ‘/nix/store/m11nsq51szvkzqnlsb3k7skqzh2781jp-openttd-1.8.0/bin/openttd -h’ got 0 exit code
- ran ‘/nix/store/m11nsq51szvkzqnlsb3k7skqzh2781jp-openttd-1.8.0/bin/openttd --help’ got 0 exit code
- ran ‘/nix/store/m11nsq51szvkzqnlsb3k7skqzh2781jp-openttd-1.8.0/bin/openttd help’ got 0 exit code
- ran ‘/nix/store/m11nsq51szvkzqnlsb3k7skqzh2781jp-openttd-1.8.0/bin/.openttd-wrapped -h’ got 0 exit code
- ran ‘/nix/store/m11nsq51szvkzqnlsb3k7skqzh2781jp-openttd-1.8.0/bin/.openttd-wrapped --help’ got 0 exit code
- ran ‘/nix/store/m11nsq51szvkzqnlsb3k7skqzh2781jp-openttd-1.8.0/bin/.openttd-wrapped help’ got 0 exit code
- found 1.8.0 with grep in /nix/store/m11nsq51szvkzqnlsb3k7skqzh2781jp-openttd-1.8.0
- directory tree listing: https://gist.github.com/8f8e59bc7bf394685911bd755a16c0a9
(My OCD kicked in today...)
Remove repeated package names, capitalize first word, remove trailing
periods and move overlong descriptions to longDescription.
I also simplified some descriptions as well, when they were particularly
long or technical, often based on Arch Linux' package descriptions.
I've tried to stay away from generated expressions (and I think I
succeeded).
Some specifics worth mentioning:
* cron, has "Vixie Cron" in its description. The "Vixie" part is not
mentioned anywhere else. I kept it in a parenthesis at the end of the
description.
* ctags description started with "Exuberant Ctags ...", and the
"exuberant" part is not mentioned elsewhere. Kept it in a parenthesis
at the end of description.
* nix has the description "The Nix Deployment System". Since that
doesn't really say much what it is/does (especially after removing
the package name!), I changed that to "Powerful package manager that
makes package management reliable and reproducible" (borrowed from
nixos.org).
* Tons of "GNU Foo, Foo is a [the important bits]" descriptions
is changed to just [the important bits]. If the package name doesn't
contain GNU I don't think it's needed to say it in the description
either.
