Jörg Thalheim
ed453ccb9c
CODEOWNERS: add Mic92/LnL7 for rustc
...
Mic92: linux-x86_64, linux-aarch64
LnL7: for macOS-x86_64
2018-04-09 14:47:10 +01:00
Profpatsch
99f2b33519
CODEOWNERS: Add Profpatsch to /lib/generators.nix
...
I’d like to be notified of changes so I can ensure the API always follows the same patterns.
Later (more specific) files replace more general codeowners [according to the documentation](https://help.github.com/articles/about-codeowners/ ), so I also listed `edolstra` and `nbp` again.
2018-03-24 13:35:41 +00:00
Matthew Bauer
124d47c65a
meta: fix fallout from #36275
2018-03-18 00:16:43 -05:00
John Ericson
98ede1e2ae
CODEOWNERS: Make @orivej a {cc,bintools}-wrapper codeowner
2018-01-19 16:18:27 -05:00
Eelco Dolstra
6060a6dd22
CODEOWNERS cleanup
...
I haven't worked on stdenv etc. in a long time.
2018-01-19 18:41:32 +01:00
John Ericson
cada00bc49
CODEOWNERS: Add me, @Ericson2314, to a few things
2017-12-18 19:00:43 -05:00
Thomas Tuegel
13a0433773
CODEOWNERS: Add ttuegel for Qt / KDE
2017-12-07 13:44:10 -06:00
Yegor Timoshenko
f74945755a
CODEOWNERS: exclude lib/licenses.nix
2017-11-16 20:27:16 +00:00
Orivej Desh
737e415820
Merge pull request #31534 from yegortimoshenko/patch-7
...
CODEOWNERS: exclude lib/maintainers.nix
2017-11-16 20:11:22 +00:00
Graham Christensen
cec203be16
ISSUE_TEMPLATE: replace technical details withh nix-info
2017-11-13 20:44:52 -05:00
Joerg Thalheim
0533e56671
CONTRIBUTING.md: be more precise what is meant by formatting commits
2017-11-13 09:05:18 +00:00
Yegor Timoshenko
fa9d4a3ef3
CODEOWNERS: exclude lib/maintainers.nix
...
Resolves #31401 .
2017-11-11 18:44:31 +00:00
zimbatm
088ce9f23f
CODEOWNERS: fix path notation
...
This format uses the path matching algorithm as the .gitignore format.
The paths need to be prefixed with a / to become absolute, otherwise it
will match all of these files.
The paths will also match any of the sub-paths by default so it's not
necessary to use the `*` like in bash globbing.
2017-11-01 19:05:17 +00:00
Nicolas B. Pierron
e2f8fa37f2
Flag my-self as owner of Nixpkgs and NixOS internals
2017-11-01 11:48:35 +01:00
zimbatm
4a4f6ba418
CODEOWNERS: fix path matching
2017-10-30 15:20:54 +00:00
zimbatm
abbea503b9
CODEOWNERS: add zimbatm to ruby modules
2017-10-30 15:13:47 +00:00
Joachim F
37acc1a5df
Merge pull request #29668 from vyp/doc/contributing.md
...
CONTRIBUTING.md: mention that the meta.license and meta.maintainers attributes must be set
2017-10-28 11:14:15 +00:00
Matthew Justin Bauer
b28bd2a81f
Update CODEOWNERS to use darwin-maintainers team
...
This sets up the Darwin-maintainers team as CODEOWNERS for Darwin paths. So anyone in that team will get notified (instead of just listing individuals).
/cc @org/darwin-maintainers
2017-10-12 00:38:18 -05:00
Maxime Dénès
9ca1b56683
pr template: make values of platform field less ambiguous
2017-10-09 12:53:09 +02:00
xd1le
4b25ecc7b8
CONTRIBUTING.md: license should default to unfree if there is no
...
upstream license
2017-10-09 20:37:02 +11:00
Robert Helgesson
51b557b2c8
CODEOWNERS: add @rycee for Eclipse IDE
2017-10-05 22:43:07 +02:00
xd1le
306a0d32df
CONTRIBUTING.md: mention that the meta.license and meta.maintainers
...
attributes must be set
2017-09-22 23:12:49 +10:00
Edward Tjörnhammar
d623220b78
CODEOWNERS: jetbrains
2017-09-19 10:26:29 +02:00
Profpatsch
4cbe7bda70
Remove Profpatsch from the CODEOWNERS file
...
Since CODEOWNERS shall be interpreted as actual ownership (and not just a
mentionbot replacement), I will remove myself again.
2017-09-13 19:56:13 +02:00
Gleb Peregud
c041770f2c
Add gleber to CODEOWNERs of beam-related packages.
2017-09-11 23:03:49 +02:00
Eelco Dolstra
24646266bb
Set ownership of CODEOWNERS
2017-09-07 12:19:54 +02:00
Eelco Dolstra
adb8a0a7e1
Change owner of stdenv and lib
2017-09-07 12:17:36 +02:00
Peter Simons
b1ca0f465f
CODEOWNERS: (align-regexp "@") my code blocks
2017-09-07 09:07:40 +02:00
Peter Simons
88d11c4e4b
CODEOWNERS: tabs are evil
2017-09-07 09:06:01 +02:00
Peter Simons
a95c577038
CODEOWNERS: add peti for R-related code
2017-09-07 09:04:30 +02:00
Peter Simons
baf9dfc476
CODEOWNERS: add peti for Haskell-related code
2017-09-07 09:04:26 +02:00
Profpatsch
6afa844d31
CODEOWNERS: add Profpatsch to various paths
2017-09-07 04:29:55 +02:00
Piotr Bogdan
e221d945ad
pr template: make formatting consistent
2017-09-03 19:57:18 +01:00
Dmitry Kalinkin
b6a1e439e1
documentation: use modern Firefox version in example
2017-09-01 14:03:28 -04:00
Linus Heckemann
02d168e130
Pull request template: comment out instructions
2017-08-12 15:17:39 +01:00
John Ericson
9b10fcce2f
Add myself to CODEOWNERS, and use tab consistently
2017-07-31 19:38:16 -04:00
Frederik Rietdijk
8977bee504
Merge pull request #27499 from FRidh/codeowners
...
CODEOWNERS file for review requests
2017-07-30 08:11:11 +02:00
Yegor Timoshenko
72239c3a22
PULL_REQUEST_TEMPLATE.md: mereley -> merely
2017-07-28 23:38:25 +00:00
Frederik Rietdijk
5414e2ae8d
CODEOWNERS file for review requests
...
Some time ago GitHub introduced the CODEOWNERS file. The file is similar
to the MAINTAINERS file that was proposed in
https://github.com/NixOS/nixpkgs/issues/13602 . Code owners will
automatically receive a review request.
2017-07-28 15:04:48 +02:00
Frederik Rietdijk
138eba0bff
Pull request template: clarify the purpose of the template
2017-07-22 18:05:16 +02:00
Bjørn Forsman
8537cf0f81
CONTRIBUTING.md: suggest "nixos/<module>" prefix for NixOS changes
...
Suggest prefixing commit messages that touches NixOS code with
"nixos/<module>" instead of the current "<name> service" prefix.
"<name> service" is limiting in that NixOS code is more than the
services. It is also easier to spot NixOS changes with explicit
"nixos/..." prefix.
2017-07-22 00:21:05 +02:00
aszlig
fa6fd34fcc
github/pr-template: Add note about NixOS tests
...
On several occasions I've seen people bumping packages which have NixOS
tests but without actually running them.
While this probably won't prevent such occasions entirely, at least it
serves as an additional checklist item so contributors don't forget
about these tests.
Signed-off-by: aszlig <aszlig@redmoonstudios.org>
2017-06-23 05:33:06 +02:00
Alexey Shmalko
f5bed28db8
github issue template: add sandboxing info
2017-05-01 15:38:11 +03:00
Hannu Hartikainen
9ed8627a76
CONTRIBUTING.md: improve commit message guidelines
...
Add a brief request for expressing the motivation for a change. Change the example commit messages to match.
Resolves #19126 .
2017-02-06 22:26:32 +02:00
Vladimír Čunát
b59167ce0e
CONTRIBUTING.md: switch to a link that actually works
...
Fixes #20594 .
2016-11-24 10:01:16 +01:00
Ignat Loskutov
d91eba4ec3
Update PULL_REQUEST_TEMPLATE.md
...
Follow the rebranding of OS X into macOS
2016-11-04 18:49:40 +03:00
zimbatm
0e3e7a6bcd
Merge pull request #18972 from ericsagnes/doc/reviewing-contributions
...
[WIP] nixos-doc: add reviewing contributions chapter
2016-10-01 15:09:12 +01:00
Eric Sagnes
7ad26bdc6e
improvements from feedback
2016-09-28 11:05:22 +09:00
Eric Sagnes
8d656d2ca0
nixos-doc: add reviewing-contributions
2016-09-26 15:44:06 +09:00
Wink Saville
0f386457e3
Update broken link in CONTRIBUTING.md
...
The current link returns a 404 error
2016-09-23 16:33:47 -07:00
Rushmore Mushambi
0192777972
PULL_REQUEST_TEMPLATE: rename chroot to sandbox
...
See b39622a487
2016-09-02 21:41:43 +02:00
Vladimír Čunát
156105c489
PR template: go back to old option name for now
...
The old one works on all nix(os) versions, whereas the new one doesn't
work e.g. on default 16.03 setting. Discussed on #15112 .
2016-06-29 21:44:05 +02:00
Daniel Peebles
0bd54a6d5d
Update PR template with motivation for changes
...
I'm seeing a lot of PRs that only include the checklist, when the main thing I care about when I'm reviewing a PR is what the author was thinking when they decided to make the change.
2016-05-24 07:59:46 -04:00
Vladimír Čunát
4c10d404e7
github PR template: reformulate the sandboxing help
...
It's been reported that when running through nix daemon,
sandboxing can't be turned on by passing `--option` (silently ignored),
so let's not suggest that way.
https://github.com/NixOS/nixpkgs/issues/14866#issuecomment-214619909
2016-04-26 09:18:15 +02:00
Vladimír Čunát
7cf8daa2bb
nixos: rename chroot* to sandbox*
...
On Nix side this was done months ago:
https://github.com/NixOS/nix/pull/682
2016-04-25 11:04:08 +02:00
zimbatm
3b33c3628a
fixup! Simplify contributing
2016-04-09 20:51:26 +01:00
zimbatm
8706726d59
Simplify contributing
...
* Highlight the top mistakes directly in CONTRIBUTING.md
* Remove unecessary cruft from the PR template
2016-04-09 17:59:35 +01:00
Jakob Gillich
0d091ffd4a
simplify ISSUE_TEMPLATE
2016-03-31 16:14:54 +02:00
Nathan Zadoks
d0b8080062
.github/PULL_REQUEST_TEMPLATE.md: use individual checkboxes for tested OSes
2016-03-16 09:46:05 +01:00
Domen Kožar
2af46e4393
PULL_REQUEST_TEMPLATE: fix issues raised in 3c84ae406
2016-02-28 09:26:28 +00:00
Domen Kožar
3c84ae406d
PULL_REQUEST_TEMPLATE.md: clarify a few things
2016-02-28 08:50:33 +00:00
Eelco Dolstra
830c2d6389
ISSUE_TEMPLATE.md: Tweak
2016-02-23 17:06:55 +01:00
Domen Kožar
71c231e2a6
Merge pull request #13388 from spacefrogg/contributing-fix
...
CONTRIBUTING.md: Fix link to COPYING
2016-02-23 14:07:19 +00:00
Michael Raitza
d53fa9884b
CONTRIBUTING.md: Fix link to COPYING
2016-02-23 13:50:01 +00:00
zimbatm
4ba3c96431
.github/ISSUE_TEMPLATE.md - get more information
...
The goal is to get all the necessary information from the reporter upfront.
Too many times the issues submits and we need to do a round of asking before
we can get close to a solution.
2016-02-23 12:09:41 +00:00
Arseniy Seroka
e4d0811c8b
Merge pull request #13100 from jagajaga/improvements
...
PULL_REQUEST_TEMPLATE: init
2016-02-22 13:47:34 +03:00
Arseniy Seroka
ac9ab2c3f5
PULL_REQUEST_TEMPLATE: init
2016-02-22 13:45:56 +03:00
Eelco Dolstra
88f5d1c8ba
Move CONTRIBUTING.md to .github
...
See https://github.com/blog/2111-issue-and-pull-request-templates .
2016-02-19 10:59:38 +01:00
