mirrors/nixpkgs
1
0
Fork 1
mirror of https://github.com/NixOS/nixpkgs.git synced 2024-11-18 03:30:45 +00:00
Code Issues Wiki Activity
686275 commits 266 branches 124 tags 6 GiB
Commit graph

97 commits

Author SHA1 Message Date
Artturin 40799fc06d treewide: replace stdenv.is in non nix files 
Continuing e0464e4788
 2024-09-27 19:07:45 +03:00
Ryan Lahfa 960b838a5f
CONTRIBUTING: offer clearer guidelines about blocker vs. non-blocker issues (#264651) 
We sometimes have reviews that are blocked because of miscommunication between author
and reviewer, we make this clear so that reviewers and authors can refer to a block of
"authoritative" text to unblock their own situations.

Co-authored-by: Valentin Gagarin <valentin@gagarin.work>
 2024-09-16 13:17:33 +02:00
Dionysis Grigoropoulos 757fe30b63
CONTRIBUTING.md: Update link to committers issue 2024-09-10 12:47:25 +03:00
Silvan Mosberger 8121f5a4bd CONTRIBUTING.md: Mention nixfmt instead of manual formatting rules 2024-07-26 00:37:42 +02:00
Silvan Mosberger ca4a5e1f20 CONTRIBUTING.md: Editorconfig instead of manual description 2024-07-26 00:33:32 +02:00
Emily e820a60e93 CONTRIBUTING.md: point to the Matrix Staging room 2024-07-23 17:30:46 +01:00
Emily 280f31043c CONTRIBUTING.md: allow using PRs to target staging-next 2024-07-23 13:35:06 +01:00
Fritz Otlinghaus 299c0dad47 CONTRIBUTING.md: Add nixpkgs-merge-bot usage paragraph 2024-05-22 19:08:20 +02:00
Weijia Wang 4a817d2083 24.05 is Vicuña 2024-05-22 18:15:34 +02:00
Silvan Mosberger 1daef0114a Remove mentions of documentation-reviewers team 
See also https://github.com/NixOS/nix.dev/pull/978
 2024-05-13 20:06:16 +02:00
Marcelo Giles 3c009e35d3
contributing: add link to rebasing+squashing 
contributing: update link to rebasing+squashing
 2024-04-20 20:15:51 -07:00
Janne Heß bc5ee2b8f8 treewide: Switch markdown placeholder from "..." to <...> 
We use angle brackets since they look a lot like a placeholder while
also being valid nix code, as suggested by roberth here: https://github.com/NixOS/nixpkgs/pull/299554#discussion_r1541797970
 2024-03-28 09:28:12 +01:00
Janne Heß fcc95ff817 treewide: Fix all Nix ASTs in all markdown files 
This allows for correct highlighting and maybe future automatic
formatting. The AST was verified to work with nixfmt only.
 2024-03-28 09:28:12 +01:00
benaryorg c3b66ce3cc
CONTRIBUTING.md: change table column order for staging 
The graph right above the table has the order as `master` ⇒ `staging-next` ⇒ `staging`.
This corresponds with the workflow, i.e. automatic merges happen in that direction and the manual merging is in reverse direction of that.
As a first time reader of this document the table was very confusing due to the disparity of that.
With this change the table should read more fluently for people not familiar with the workflow since the table follows the step-by-step flow of commits.

Signed-off-by: benaryorg <binary@benary.org>
 2024-02-23 17:28:16 +00:00
ibbem 6ef8838dcf CONTRIBUTING.md: Sandboxing is enabled by default on Linux 
The fact that sandboxing is already enabled by default is mentioned in
the pull request template. Hence, it might be confusing to ask to enable
sandboxing in CONTRIBUTING.md.

Also follow the `one sentence per line` guideline.

Co-authored-by: Silvan Mosberger <github@infinisil.com>
 2024-02-12 11:08:47 +01:00
Philipp Riegger da74a75303 doc: fix typo 2024-01-19 12:00:16 +01:00
Valentin Gagarin f1601b35e7 doc: mention new documentation-reviewers subteam 2024-01-15 21:01:21 +01:00
Silvan Mosberger e88fb997e3 CONTRIBUTING.md: Dedent warnings until GitHub fixes it 
https://github.com/orgs/community/discussions/16925#discussioncomment-7574895
 2023-12-06 04:04:01 +01:00
Silvan Mosberger 4769458228 CONTRIBUTING.md: Update markdown emphasising syntax 
GitHub supported special markdown syntax for emphasising blocks for some
time. This was however a beta feature, and still is, so it's subject to
changes.

Recently such a change happened: The syntax is different now.

See https://github.com/orgs/community/discussions/16925 for more
information
 2023-12-06 03:51:39 +01:00
figsoda 43a3d2d90e {CONTRIBUTING,PULL_REQUEST_TEMPLATE}.md: update NixOS release 2023-11-27 17:33:01 -05:00
Silvan Mosberger e89ad83555
Merge pull request #263059 from DanielSidhion/add-doc-convention 
doc: commit header convention for documentation changes
 2023-11-14 08:11:41 +01:00
DS e93a3d7b58 doc: separate commit header conventions for each area, info on docs changes. 2023-11-13 20:41:08 -08:00
Silvan Mosberger fdee770336
Merge pull request #263575 from pbsds/contributing-link-naming-conventino 
CONTRIBUTING: Add hotlinks to package and module reviewing guides, minor touchups
 2023-11-13 14:01:33 +01:00
Peder Bergebakken Sundt 8feb68f965 {pkgs,nixos}/README.md: Hotlink package and module reviewing guidelines, fix references 2023-11-13 13:46:14 +01:00
Anthony Roussel e30f48be94
treewide: fix redirected and broken URLs 
Using the script in maintainers/scripts/update-redirected-urls.sh
 2023-11-11 10:49:01 +01:00
Shahar "Dawn" Or 54b6d7de0f
Update CONTRIBUTING.md 2023-11-09 14:53:23 +07:00
h7x4 216b2bdf7f
CONTRIBUTING.md: fix a missing sentence ending 2023-10-21 02:04:09 +02:00
Kenichi Kamiya 9961e93d6b
CONTRIBUTING.md: fix a typo of link to maintainers 2023-10-16 19:15:13 +09:00
Silvan Mosberger 433f935d10 CONTRIBUTING.md: Reword changes acceptable for backport 
It wasn't entirely clear if the list was acceptable or not from the
wording.
 2023-09-06 20:12:50 +02:00
Matthias Beyer aa25691630
CONTRIBUTING: Add note about how to commit new maintainers-list.nix entry 
Signed-off-by: Matthias Beyer <mail@beyermatthias.de>
 2023-09-04 10:29:20 +02:00
Hraban Luyat 3a8f2d0e9f docs: fix link to Nix manual on sandbox config 2023-08-28 14:12:27 -04:00
Anderson Torres c483f199f7 CONTRIBUTING: remove suggestion about the order of arguments 
Particularities about style should be enforced at the tooling level (linters,
code beautifiers etc.). Otherwise, it adds more weight on the PR reviewing,
distracting both authors and reviewers from the substance of the changes.
 2023-08-20 11:10:34 -03:00
Silvan Mosberger de5a39f5e7 CONTRIBUTING.md: Move boot loader-specific sentence to pkgs/README.md 
This needs a rewrite at some point..
 2023-08-14 19:50:02 +02:00
Silvan Mosberger 2ce1e0b2cc CONTRIBUTING.md: Typos and formatting 
- Fix sentence about meeting contributing standards
- pkgs -> packages
- Use emoji's because GitHub renders the :*: things weird sometimes
- Move a dot

Co-authored-by: Rémi NICOLE <minijackson@users.noreply.github.com>
 2023-08-14 19:49:29 +02:00
Silvan Mosberger 237799aa8e CONTRIBUTING.md: Minor content updates based on reviews 
- Contributing without a GitHub account
- Mention OfBorg
- nix.useSandbox -> nix.settings.sandbox
- nixpkgs-review is good for not just version updates

Co-authored-by: Rémi NICOLE <minijackson@users.noreply.github.com>
 2023-08-14 19:49:02 +02:00
Silvan Mosberger b069d2dfec CONTRIBUTING.md: Move sections around 
Yeah I'm totally getting lazy with the commits, but it's really hard and
takes a long time..
 2023-08-14 03:48:41 +02:00
Silvan Mosberger 16651342ea CONTRIBUTING.md: Minor fixes 2023-08-14 02:51:00 +02:00
Silvan Mosberger 0bd8c9b4f9 CONTRIBUTING.md: New section on which branch to use 2023-08-14 02:20:56 +02:00
Silvan Mosberger 2a99b5a703 CONTRIBUTING.md: Move rebasing section up 
Right into the "How to propose a change" section, because that's where
it's relevant
 2023-08-13 22:34:34 +02:00
Silvan Mosberger 2f345d070b CONTRIBUTING.md: Remove duplicated section 
How to force push to PR's is already explained in the
"How to propose a change" section at the beginning
 2023-08-13 22:32:45 +02:00
Silvan Mosberger 4e3064d1b9 CONTRIBUTING.md: Minor formatting fixes 2023-08-13 22:29:52 +02:00
Silvan Mosberger 3639a9e482 CONTRIBUTING.md: Clean up releases section 2023-08-13 22:04:58 +02:00
Silvan Mosberger b665608845 CONTRIBUTING.md: Move release sections together 
Will be cleaned up in the next commit
 2023-08-13 22:04:58 +02:00
Silvan Mosberger 9cae39708b CONTRIBUTING.md: Clean up and condense staging workflow section 2023-08-13 22:04:57 +02:00
Silvan Mosberger 7ab012c60c CONTRIBUTING.md: Replace staging workflow diagram 
Can't be rendered in GitHub markdown, replacing it with a Git branch diagram using mermaid
 2023-08-13 22:04:57 +02:00
Silvan Mosberger aace54f1aa CONTRIBUTING.md: Move flow of changes section up 2023-08-13 22:04:57 +02:00
Silvan Mosberger 5789cc3754 CONTRIBUTING.md: Clean up "Making patches" section 
Moving and collecting bits into the appropriate places, also writing
some new sentences
 2023-08-13 22:04:57 +02:00
Silvan Mosberger 67ae88c072 CONTRIBUTING.md: Write a new section on how to propose a change 
Removing paragraphs from the other sections that aren't necessary anymore
 2023-08-13 22:04:57 +02:00
Silvan Mosberger 99c6942d83 CONTRIBUTING.md: Coding conventions -> code conventions 
It's not conventions about how to do coding, it's about what the code
should look like
 2023-08-13 22:04:57 +02:00
Silvan Mosberger dfe311b1b8 CONTRIBUTING.md: Collect paragraphs into a new commit conventions section 2023-08-13 22:04:57 +02:00