From dd40d6196bfb2316042d5744e2a1b0dddc4c4da1 Mon Sep 17 00:00:00 2001
From: Nicolas Pierron <nicolas.b.pierron@gmail.com>
Date: Tue, 15 Sep 2009 14:09:11 +0000
Subject: [PATCH] Use only one merge to compute option definitions and option
 declarations.

svn path=/nixos/trunk/; revision=17165
---
 lib/eval-config.nix | 25 ++++++++++---------------
 1 file changed, 10 insertions(+), 15 deletions(-)

diff --git a/lib/eval-config.nix b/lib/eval-config.nix
index 2eb0435d24da..be683c8b2fad 100644
--- a/lib/eval-config.nix
+++ b/lib/eval-config.nix
@@ -19,10 +19,12 @@ rec {
   configComponents = modules ++ baseModules;
 
   # Merge the option definitions in all modules, forming the full
-  # system configuration.  This is called "configFast" because it's
-  # not checked for undeclared options.
-  configFast =
-    pkgs.lib.definitionsOf configComponents extraArgs;
+  # system configuration.  It's not checked for undeclared options.
+  systemModule =
+    pkgs.lib.fixMergeModules configComponents extraArgs;
+
+  optionDefinitions = systemModule.config;
+  optionDeclarations = systemModule.options;
 
   # These are the extra arguments passed to every module.  In
   # particular, Nixpkgs is passed through the "pkgs" argument.
@@ -53,19 +55,12 @@ rec {
           # define nixpkgs.config, so it's pointless to evaluate them.
           baseModules = [ ../modules/misc/nixpkgs.nix ];
           pkgs = import nixpkgs { inherit system; config = {}; };
-        }).configFast.nixpkgs.config;
+        }).optionDefinitions.nixpkgs.config;
     };
 
-  # "fixableDeclarationsOf" is used instead of "declarationsOf" because some
-  # option default values may depends on the definition of other options.
-  # !!! This seems inefficent.  Didn't definitionsOf already compute
-  # the option declarations?
-  optionDeclarations =
-    pkgs.lib.fixableDeclarationsOf configComponents extraArgs configFast;
-
   # Optionally check wether all config values have corresponding
   # option declarations.
-  config = pkgs.checker configFast
-    configFast.environment.checkConfigurationOptions
-    optionDeclarations configFast;
+  config = pkgs.checker optionDefinitions
+    optionDefinitions.environment.checkConfigurationOptions
+    optionDeclarations optionDefinitions;
 }