From d23dcbb9a566dde560a30bcf29dde25f1540526b Mon Sep 17 00:00:00 2001 From: aszlig Date: Thu, 21 Jun 2012 17:27:36 +0200 Subject: [PATCH] chromium: Enable parallel building. Always did this manually by putting -j8 into make flags, which i didn't commit, as it obviously doesn't make sense to hardcode. However, this flag makes more sense and obviously we need to avoid overriding buildPhase. --- .../networking/browsers/chromium/default.nix | 20 ++++++++++++++----- 1 file changed, 15 insertions(+), 5 deletions(-) diff --git a/pkgs/applications/networking/browsers/chromium/default.nix b/pkgs/applications/networking/browsers/chromium/default.nix index 308547673cef..a486c80e185d 100644 --- a/pkgs/applications/networking/browsers/chromium/default.nix +++ b/pkgs/applications/networking/browsers/chromium/default.nix @@ -139,18 +139,28 @@ in stdenv.mkDerivation rec { buildType = "Release"; + enableParallelBuilding = true; + configurePhase = '' python build/gyp_chromium --depth "$(pwd)" ${gypFlags} ''; - extraBuildFlags = let + makeFlags = let CC = "${gcc}/bin/gcc"; CXX = "${gcc}/bin/g++"; - in "CC=\"${CC}\" CXX=\"${CXX}\" CC.host=\"${CC}\" CXX.host=\"${CXX}\" LINK.host=\"${CXX}\""; + in [ + "CC=${CC}" + "CXX=${CXX}" + "CC.host=${CC}" + "CXX.host=${CXX}" + "LINK.host=${CXX}" + ]; - buildPhase = '' - make ${extraBuildFlags} BUILDTYPE=${buildType} library=shared_library chrome - ''; + buildFlags = [ + "BUILDTYPE=${buildType}" + "library=shared_library" + "chrome" + ]; installPhase = '' mkdir -vp "$out/libexec/${packageName}"