mirrors/nixpkgs
1
0
Fork 1
mirror of https://github.com/NixOS/nixpkgs.git synced 2024-11-22 13:41:26 +00:00
Code Issues Wiki Activity

nixos/sanoid: Extract datasets rather than pools

Browse source 
When making new snapshots we only need to delegate permissions to the
specific dataset rather than the entire pool.
This commit is contained in:
Elis Hirwing 2021-07-25 10:00:37 +02:00
parent 70862830f0
commit bb35e7c404
No known key found for this signature in database
GPG key ID: D57EFA625C9A925F
1 changed files with 8 additions and 8 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

16
nixos/modules/services/backup/sanoid.nix
View file

@ -70,8 +70,8 @@ let
processChildrenOnly = process_children_only;
};
# Extract pool names from configured datasets
pools = unique (map (d: head (builtins.match "([^/]+).*" d)) (attrNames cfg.datasets));
# Extract unique dataset names
datasets = unique (attrNames cfg.datasets);
configFile = let
mkValueString = v:
@ -156,18 +156,18 @@ in {
systemd.services.sanoid = {
description = "Sanoid snapshot service";
serviceConfig = {
ExecStartPre = map (pool: lib.escapeShellArgs [
ExecStartPre = map (dataset: lib.escapeShellArgs [
"+/run/booted-system/sw/bin/zfs" "allow"
"sanoid" "snapshot,mount,destroy" pool
]) pools;
"sanoid" "snapshot,mount,destroy" dataset
]) datasets;
ExecStart = lib.escapeShellArgs ([
"${pkgs.sanoid}/bin/sanoid"
"--cron"
"--configdir" (pkgs.writeTextDir "sanoid.conf" configFile)
] ++ cfg.extraArgs);
ExecStopPost = map (pool: lib.escapeShellArgs [
"+/run/booted-system/sw/bin/zfs" "unallow" "sanoid" pool
]) pools;
ExecStopPost = map (dataset: lib.escapeShellArgs [
"+/run/booted-system/sw/bin/zfs" "unallow" "sanoid" dataset
]) datasets;
User = "sanoid";
Group = "sanoid";
DynamicUser = true;