mirrors/nixpkgs
1
0
Fork 1
mirror of https://github.com/NixOS/nixpkgs.git synced 2024-11-21 13:10:33 +00:00
Code Issues Wiki Activity

nixos/nextcloud: Rename services.nextcloud.nginx.disableImagemagick to services.nextcloud.nginx.enableImagemagick

Browse source 
Enable options are preferred. Suggested here:
https://github.com/NixOS/nixpkgs/pull/115372#issuecomment-821900334
This commit is contained in:
Benjamin Koch 2021-04-22 02:17:12 +02:00
parent eef5121007
commit 8122221c9b
2 changed files with 9 additions and 8 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

15
nixos/modules/services/web-apps/nextcloud.nix
View file

@ -10,7 +10,7 @@ let
extensions = { enabled, all }: extensions = { enabled, all }:
(with all; (with all;
enabled enabled
++ optional (!cfg.disableImagemagick) imagick ++ optional cfg.enableImagemagick imagick
# Optionally enabled depending on caching settings # Optionally enabled depending on caching settings
++ optional cfg.caching.apcu apcu ++ optional cfg.caching.apcu apcu
++ optional cfg.caching.redis redis ++ optional cfg.caching.redis redis
@ -63,6 +63,9 @@ in {
Further details about this can be found in the `Nextcloud`-section of the NixOS-manual Further details about this can be found in the `Nextcloud`-section of the NixOS-manual
(which can be openend e.g. by running `nixos-help`). (which can be openend e.g. by running `nixos-help`).
'') '')
(mkRemovedOptionModule [ "services" "nextcloud" "disableImagemagick" ] ''
Use services.nextcloud.nginx.enableImagemagick instead.
'')
]; ];
options.services.nextcloud = { options.services.nextcloud = {
@ -303,16 +306,14 @@ in {
}; };
}; };
disableImagemagick = mkOption { enableImagemagick = mkEnableOption ''
type = types.bool; Whether to load the ImageMagick module into PHP.
default = false;
description = ''
Whether to not load the ImageMagick module into PHP.
This is used by the theming app and for generating previews of certain images (e.g. SVG and HEIF). This is used by the theming app and for generating previews of certain images (e.g. SVG and HEIF).
You may want to disable it for increased security. In that case, previews will still be available You may want to disable it for increased security. In that case, previews will still be available
for some images (e.g. JPEG and PNG). for some images (e.g. JPEG and PNG).
See https://github.com/nextcloud/server/issues/13099 See https://github.com/nextcloud/server/issues/13099
''; '' // {
default = true;
}; };
caching = { caching = {

2
nixos/tests/nextcloud/basic.nix
View file

@ -51,7 +51,7 @@ in {
nextcloudWithoutMagick = args@{ config, pkgs, lib, ... }: nextcloudWithoutMagick = args@{ config, pkgs, lib, ... }:
lib.mkMerge lib.mkMerge
[ (nextcloud args) [ (nextcloud args)
{ services.nextcloud.disableImagemagick = true; } ]; { services.nextcloud.enableImagemagick = false; } ];
}; };
testScript = { nodes, ... }: let testScript = { nodes, ... }: let