mirrors/nixpkgs
1
0
Fork 1
mirror of https://github.com/NixOS/nixpkgs.git synced 2024-11-19 20:21:14 +00:00
Code Issues Wiki Activity

libaom: use git stub instead of patching changelog

Browse source 
It probably needs less maintenance.
This commit is contained in:
Jörg Thalheim 2018-12-17 23:22:17 +01:00
parent cee81d59ac
commit 1720abc263
No known key found for this signature in database
GPG key ID: CA4106B8D7CC79FA
1 changed files with 15 additions and 26 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

41
pkgs/development/libraries/libaom/default.nix
View file

@ -1,4 +1,4 @@
{ stdenv, fetchgit, yasm, perl, cmake, pkgconfig, python3Packages, writeText }:
{ stdenv, fetchgit, yasm, perl, cmake, pkgconfig, python3, writeText }:
stdenv.mkDerivation rec {
name = "libaom-${version}";
@ -10,33 +10,22 @@ stdenv.mkDerivation rec {
sha256 = "07h2vhdiq7c3fqaz44rl4vja3dgryi6n7kwbwbj1rh485ski4j82";
};
buildInputs = [ perl yasm ];
nativeBuildInputs = [ cmake pkgconfig python3Packages.python ];
nativeBuildInputs = [
yasm perl cmake pkgconfig python3
];
cmakeFlags = [ "-DBUILD_SHARED_LIBS=ON" ];
cmakeFlags = [
"-DBUILD_SHARED_LIBS=ON"
];
# * libaom tries to detect what version it is
# * I couldn't get it to grab this from git info,
# (which needs at least leaveDotGit=true)
# * it uses a perl script to parse from CHANGELOG,
# but 1.0.0 doesn't contain an entry for itself :(
# * Upstream patch that adds the entry also nukes all of
# the versions before a project change (open-sourcing?)
# and as a result is 34K which is way too big just to fix this!
# * A stable URL to fetch this from works, but...
# * Upon inspection the resulting CHANGELOG is shorter
# than this comment, so while yes this is a bit gross
# adding these 4 lines here does the job without
# a huge patch in spirit of preferring upstream's fix
# instead of `sed -i 's/v0\.1\.0/v1.0.0/g' aom.pc` or so.
postPatch = let actual_changelog = writeText "CHANGELOG" ''
2018-06-28 v1.0.0
AOMedia Codec Workgroup Approved version 1.0
2016-04-07 v0.1.0 "AOMedia Codec 1"
This release is the first Alliance for Open Media codec.
''; in ''
cp ${actual_changelog} CHANGELOG
preConfigure = ''
# build uses `git describe` to set the build version
cat > $NIX_BUILD_TOP/git << "EOF"
#!${stdenv.shell}
echo v${version}
EOF
chmod +x $NIX_BUILD_TOP/git
export PATH=$NIX_BUILD_TOP:$PATH
'';
meta = with stdenv.lib; {