3
0
Fork 0
forked from mirrors/nixpkgs
nixpkgs/pkgs/servers/openxpki/default.nix
Alyssa Ross fd78240ac8
treewide: use lib.getLib for OpenSSL libraries
At some point, I'd like to make another attempt at
71f1f4884b ("openssl: stop static binaries referencing libs"), which
was reverted in 195c7da07d.  One problem with my previous attempt is
that I moved OpenSSL's libraries to a lib output, but many dependent
packages were hardcoding the out output as the location of the
libraries.  This patch fixes every such case I could find in the tree.
It won't have any effect immediately, but will mean these packages
will automatically use an OpenSSL lib output if it is reintroduced in
future.

This patch should cause very few rebuilds, because it shouldn't make
any change at all to most packages I'm touching.  The few rebuilds
that are introduced come from when I've changed a package builder not
to use variable names like openssl.out in scripts / substitution
patterns, which would be confusing since they don't hardcode the
output any more.

I started by making the following global replacements:

    ${pkgs.openssl.out}/lib -> ${lib.getLib pkgs.openssl}/lib
    ${openssl.out}/lib -> ${lib.getLib openssl}/lib

Then I removed the ".out" suffix when part of the argument to
lib.makeLibraryPath, since that function uses lib.getLib internally.

Then I fixed up cases where openssl was part of the -L flag to the
compiler/linker, since that unambigously is referring to libraries.

Then I manually investigated and fixed the following packages:

 - pycurl
 - citrix-workspace
 - ppp
 - wraith
 - unbound
 - gambit
 - acl2

I'm reasonably confindent in my fixes for all of them.

For acl2, since the openssl library paths are manually provided above
anyway, I don't think openssl is required separately as a build input
at all.  Removing it doesn't make a difference to the output size, the
file list, or the closure.

I've tested evaluation with the OfBorg meta checks, to protect against
introducing evaluation failures.
2022-03-30 15:10:00 +00:00

84 lines
4.4 KiB
Nix

{ lib, fetchgit, perl, openssl, perlPackages, gettext, python3Packages
# TODO: Remove extra dependencies once it is clear that they are NOT needed somewhere.
, extraDependencies1 ? false, extraDependencies2 ? false, extraDependencies3 ? false }:
perlPackages.buildPerlPackage {
pname = "openxpki";
version = "git20150807";
src = fetchgit {
url = "https://github.com/openxpki/openxpki";
rev = "5cb76c553b6b1a81ede380857700628a7521f6e3";
sha256 = "05bmhani2c7ays488xv3hx5xbxb612bnwq5rdjwmsj51xpaz454p";
};
buildInputs = [ perl openssl gettext python3Packages.sphinx ];
propagatedBuildInputs = with perlPackages;
[ # dependencies from Makefile.PL
libintl-perl ConfigVersioned LWP ClassAccessorChained IOSocketSSL ClassStd
CGISession ConfigStd ConfigMerge Connector CryptCBC CryptOpenSSLAES CryptPKCS10
DBDMock DataPassword DataSerializer DateTimeFormatDateParse IOPrompt
IPCShareLite JSON LogLog4perl LWPProtocolConnect LWPProtocolHttps MailRFC822Address
Moose NetAddrIP NetDNS NetIP perlldap NetHTTP NetServer NetSSLeay ParamsValidate PathClass
ProcProcessTable ProcSafeExec RegexpCommon SOAPLite Switch SysSigAction TemplateToolkit
TestPod TestPodCoverage TextCSV_XS Workflow XMLFilterXInclude XMLParser
XMLSAX XMLSAXWriter XMLSimple XMLValidatorSchema ]
++ lib.optionals extraDependencies1
[ # dependencies from parsing through core/server
ClassAccessor PathTools DataDumper DateTime DateTimeFormatStrptime DBI
Encode ExceptionClass FilePath FileTemp Filter GetoptLong HTMLParser
ScalarListUtils MathBigInt Memoize libnet RTClientREST
Storable ]
++ lib.optionals extraDependencies2
[ # dependencies taken from Debian
MooseXTypesPathClass DataStreamBulk MooseXStrictConstructor GitPurePerl
ConfigGitLike DevelStackTrace TreeDAGNode ClassObservable ClassFactory TimeDate ConfigAny
CGIFast ClassISA YAML YAMLLibYAML AuthenSASL TextCSV FileFindRulePerl IODigest ]
++ lib.optionals extraDependencies3
[ # dependencies taken from https://metacpan.org/pod/release/ALECH/Bundle-OpenXPKI-0.06/lib/Bundle/OpenXPKI.pm
AttributeParamsValidate BC CGI CPAN CacheCache ClassClassgenclassgen
ClassContainer ClassDataInheritable ClassSingleton ConvertASN1 DBDSQLite DBIxHTMLViewLATEST
DBFile DataPage DataSpreadPagination DateTimeLocale DateTimeTimeZone DevelPPPort
DevelSymdump DigestSHA1 Env Error ExtUtilsConstant ExtUtilsInstall
ExtUtilsMakeMaker FileCheckTree GoferTransporthttp HTMLMason HTMLTagset
HTTPServerSimpleMason IO IPCSysV LocaleCodes LogDispatch MathBigRat
MathRound ModuleBuild ModuleBuildDeprecated NetPing PodChecker
PodCoverage PodLaTeX PodParser PodPerldoc PodPlainer PodSimple
SubUplevel SysSyslog TemplatePluginAutoformat TermReadKey TestException
TestHTTPServerSimple TestHarnessStraps TextBalanced TextIconv TextSoundex
ThreadQueue TieFile TieRefHash TimeLocal URI
UnicodeNormalize WWWMechanize Want XMLFilterBufferText XMLNamespaceSupport bignum
libapreq2 libnet podlators threadsshared version ];
preConfigure = ''
substituteInPlace core/server/Makefile.PL \
--replace "my \$openssl_inc_dir = ''';" "my \$openssl_inc_dir = '${openssl.dev}/include';" \
--replace "my \$openssl_lib_dir = ''';" "my \$openssl_lib_dir = '${lib.getLib openssl}/lib';" \
--replace "my \$openssl_binary = ''';" "my \$openssl_binary = '${openssl.bin}/bin/openssl';"
substituteInPlace tools/vergen --replace "#!/usr/bin/perl" "#!${perl}/bin/perl"
cp ${./vergen_revision_state} .vergen_revision_state
cd core/server
'';
postInstall = ''
mkdir -p $out/share/openxpki
cp -r ../htdocs_source $out/share/openxpki/.
cp -r ../../config $out/share/openxpki/.
cp -r ../../qatest $out/share/openxpki/.
(cd ../i18n; make scan; make; make install PREFIX=$out)
(cd ../../clients/perl/OpenXPKI-Client-Enrollment; perl Makefile.PL PREFIX=$out; make; make install PREFIX=$out)
(cd ../../doc; make html man; cp _build/man/* $out/share/man/man1/.; mkdir -p $out/share/openxpki/doc; cp -r _build/{html,doctrees} $out/share/openxpki/doc/.)
'';
doCheck = false;
meta = {
homepage = "http://www.openxpki.org";
description = "Enterprise-grade PKI/Trustcenter software";
license = lib.licenses.asl20;
maintainers = with lib.maintainers; [ tstrobel ];
platforms = with lib.platforms; linux;
broken = true; # broken with openssl 1.1 (v2.x might fix this)
};
}