3
0
Fork 0
forked from mirrors/nixpkgs
nixpkgs/pkgs/applications
Joachim Fasting ecd0e1a2c7
torbrowser: reduce risk of stale Nix store references
This patch restructures the expression and wrapper to minimize Nix store
references captured by the user's state directory.

The previous version would write lots of references to the Nix store into
the user's state directory, resulting in synchronization issues between
the Store and the local state directory.  At best, this would cause TBB to
stop working when the version used to instantiate the local state was
garbage collected; at worst, a user would continue to use the old version
even after an upgrade.

To solve the issue, hard-code as much as possible at the Store side and
minimize the amount of stuff being copied into the local state dir.
Currently, only a few files generated at firefox startup and fontconfig
cache files end up capturing store paths; these files are simply removed
upon every startup.  Otherwise, no capture should occur and the user
should always be using the TBB associated with the tor-browser wrapper
script.

To check for stale Store paths, do
   `grep -Ero '/nix/store/[^/]+' ~/.local/share/tor-browser`
This command should *never* return any other store path than the one
associated with the current tor-browser wrapper script, even after an
update (assuming you've run tor-browser at least once after updating).
Deviations from this general rule are considered bugs from now on.

Note that no attempt has been made to support pluggable transports; they
are still broken with this patch (to be fixed in a follow-up patch).

User visible changes:
- Wrapper retains only environment variables required for TBB to work
- pulseaudioSupport can be toggled independently of mediaSupport (the
  latter weakly implies the former).
- Store local state under $TBB_HOME.  Defaults to $XDG_DATA_HOME/tor-browser
- Stop obnoxious first-run stuff (NoScript redirect, in particular)
- Set desktop item GenericName to Web Browser

Some minor enhancements:
- Disable Hydra builds
- Specify system -> source mapping to make it easier to
  extend supported platforms.
2017-03-25 15:59:18 +01:00
..
altcoins freicoin: Fix eval 2017-03-25 02:12:14 +02:00
audio gpodder: add myself as maintainer 2017-03-21 17:12:55 +01:00
backup
display-managers sddm: fix wrapper 2017-03-24 09:46:05 -05:00
editors vscode: 1.10.0 -> 1.10.2 2017-03-24 16:48:24 -04:00
gis qgis: Fix build after pythonPackages.sip update 2017-03-13 16:05:31 +01:00
graphics feh: Remove un-needed libPath 2017-03-21 16:27:55 -05:00
inferno
kde kdelibs: remove sanitize patch 2017-03-18 17:46:36 +01:00
misc Merge pull request #24224 from ndowens/freicoin 2017-03-24 23:42:52 +01:00
networking torbrowser: reduce risk of stale Nix store references 2017-03-25 15:59:18 +01:00
office libreoffice-fresh: 5.3.0.3 -> 5.3.1.2 2017-03-18 21:27:31 +01:00
science geogebra: 5-0-338-0 -> 5-0-346-0 2017-03-24 22:16:57 +01:00
search recoll: 1.21.3 -> 1.23.1 2017-03-22 17:14:30 -05:00
taxes
version-management gitkraken: clean-up 2017-03-25 12:52:01 +01:00
video kodi: 17.0 -> 17.1 2017-03-24 08:19:16 +08:00
virtualization virt-manager: 1.4.0 -> 1.4.1 (#24149) 2017-03-21 10:20:55 +01:00
window-managers awesome: menubar should take XDG_HOME_DIR and XDG_DATA_DIRS into account 2017-03-23 17:52:18 +01:00