3
0
Fork 0
forked from mirrors/nixpkgs
nixpkgs/pkgs/build-support/setup-hooks
Chuck a45b3ad89f
makeWrapper: Remove unused extraFlagsArray feature
There is a bug in this feature: It allows extra arguments to leak in
from the environment. For example:

  $ export extraFlagsArray=date
  $ man ls

Note that you get the man page for date rather than for ls. This happens
because 'man' happens to use a wrapper (to add groff to its PATH).

An attempt to fix this was made in 5ae18574fc in PR #19328 for
issue #2537, but 1. That change didn't actually fix the problem because
it addressed makeWrapper's environment during the build process, not the
constructed wrapper script's environment after installation, and 2. That
change was apparently accidentally lost when merged with 7ff6eec5fd.

Rather than trying to fix the bug again, we remove the extraFlagsArray
feature, since it has never been used in the public repo in the ten
years it has been available.

wrapAclocal continues to use its own, separate flavor of extraFlagsArray
in a more limited context. The analogous bug there was fixed in
4d7d10da6b in 2011.
2019-09-25 09:23:09 -07:00
..
audit-tmpdir.sh audit-tmpdir hook: clean up whitespace 2018-12-02 11:45:34 +01:00
auto-patchelf.sh auto-patchelf: don't use grep -q, as it causes Broken pipe (#56958) 2019-03-20 14:57:59 +02:00
autoreconf.sh
breakpoint-hook.sh breakpointHook: add for debugging failing builds 2018-10-25 10:19:41 +01:00
compress-man-pages.sh
die.sh
enable-coverage-instrumentation.sh
find-xml-catalogs.sh
fix-darwin-dylib-names.sh gcj: fix build on Darwin 2019-01-30 18:19:17 +00:00
gog-unpack.sh
install-shell-files.sh installShellFiles: init (#65211) 2019-09-04 23:19:17 +02:00
keep-build-tree.sh
ld-is-cc-hook.sh
make-coverage-analysis-report.sh
make-wrapper.sh makeWrapper: Remove unused extraFlagsArray feature 2019-09-25 09:23:09 -07:00
move-docs.sh
move-lib64.sh
move-sbin.sh
multiple-outputs.sh
patch-shebangs.sh patchShebangs: Exit if no arguments were given 2019-05-26 16:05:06 +02:00
prune-libtool-files.sh pruneLibtoolFiles: check if prefix exists 2018-12-09 22:44:29 +00:00
role.bash
separate-debug-info.sh
set-java-classpath.sh
set-source-date-epoch-to-latest.sh set-source-date-epoch-to-latest: fix warning 2018-11-29 09:49:08 +01:00
setup-debug-info-dirs.sh
shorten-perl-shebang.sh add shortenPerlShebang function 2019-08-18 16:22:23 -07:00
strip.sh
update-autotools-gnu-config-scripts.sh
use-old-cxx-abi.sh
win-dll-link.sh
wrap-gapps-hook.sh wrapGAppsHook: address some shellcheck suggestions 2019-09-10 16:24:11 +02:00