3
0
Fork 0
forked from mirrors/nixpkgs
nixpkgs/pkgs/applications/networking/browsers/chromium
Michael Weiss d6d4228b39
chromiumBeta: Backport a patch to fix the build
The build was failing with:
In file included from ../../third_party/blink/renderer/modules/webcodecs/audio_encoder.cc:7:
In file included from ../../media/audio/audio_opus_encoder.h:16:
gen/shim_headers/opus_shim/third_party/opus/src/include/opus.h:5:10: error: 'opus.h' file not found with <angled> include; use "quotes" instead
#include <opus.h>
         ^~~~~~~~
         "opus.h"
[...]
fatal error: too many errors emitted, stopping now [-ferror-limit=]
20 errors generated.
[42272/44233] CXX obj/third_party/blink/renderer/modules/webcodecs/webcodecs/decoder_template.oo[K

Note: This also fixes the ungoogled-chromium channel name in versionRange.
2021-01-30 12:08:17 +01:00
..
patches chromium: Drop the libwebp include patch 2020-10-15 14:33:15 +02:00
browser.nix treewide: remove stdenv where not needed 2021-01-25 18:31:47 +01:00
common.nix chromiumBeta: Backport a patch to fix the build 2021-01-30 12:08:17 +01:00
default.nix treewide: stdenv.lib -> lib 2021-01-16 17:58:11 +07:00
plugins.nix treewide: stdenv.lib -> lib 2021-01-16 17:58:11 +07:00
README.md chromium/doc: Explain how to run the VM tests 2021-01-20 19:23:59 +01:00
ungoogled.nix ungoogled-chromium: Merge back into chromium 2020-12-10 17:41:11 +01:00
update.py chromium: Fix the version comparison in print_updates() 2021-01-28 15:45:00 +01:00
upstream-info.json chromiumDev: 89.0.4389.23 -> 90.0.4400.8 2021-01-28 21:30:26 +01:00

Maintainers

  • TODO: We need more maintainers:
    • https://github.com/NixOS/nixpkgs/issues/78450
    • If you just want to help out without becoming a maintainer:
      • Look for open Nixpkgs issues or PRs related to Chromium
      • Make your own PRs (but please try to make reviews as easy as possible)
  • Primary maintainer (responsible for updating Chromium): @primeos
  • Testers (test all stable channel updates)
    • nixos-unstable:
      • x86_64: @danielfullmer
      • aarch64: @thefloweringash
    • Stable channel:
      • x86_64: @Frostman
  • Other relevant packages:
    • chromiumBeta and chromiumDev: For testing purposes (not build on Hydra)
    • google-chrome, google-chrome-beta, google-chrome-dev: Updated via Chromium's upstream-info.json
    • ungoogled-chromium: Based on chromium (the expressions are regularly copied over and patched accordingly)

Upstream links

Updating Chromium

Simply run ./pkgs/applications/networking/browsers/chromium/update.py to update upstream-info.json. After updates it is important to test at least nixosTests.chromium (or basic manual testing) and google-chrome (which reuses upstream-info.json).

To run all automated NixOS VM tests for Chromium, ungoogled-chromium, and Google Chrome (not recommended, currently 6x tests!):

nix-build nixos/tests/chromium.nix

A single test can be selected, e.g. to test ungoogled-chromium (see channelMap in nixos/tests/chromium.nix for all available options):

nix-build nixos/tests/chromium.nix -A ungoogled

(Note: Testing Google Chrome requires export NIXPKGS_ALLOW_UNFREE=1.)

For custom builds it's possible to "override" channelMap.

Backports

All updates are considered security critical and should be ported to the stable channel ASAP. When there is a new stable release the old one should receive security updates for roughly one month. After that it is important to mark Chromium as insecure (see 69e4ae56c4 for an example; it is important that the tested job still succeeds and that all browsers that use upstream-info.json are marked as insecure).

Major version updates

Unfortunately, Chromium regularly breaks on major updates and might need various patches. Either due to issues with the Nix build sandbox (e.g. we cannot fetch dependencies via the network and do not use standard FHS paths) or due to missing upstream fixes that need to be backported.

Good sources for such patches and other hints:

If the build fails immediately due to unknown compiler flags this usually means that a new major release of LLVM is required.

Beta and Dev channels

Those channels are only used to test and fix builds in advance. They may be broken at times and must not delay stable channel updates.