3
0
Fork 0
forked from mirrors/nixpkgs
nixpkgs/.github
Léo Gaspard 211fee9c43
pull request template: cleanup (#117537)
Remove elements of the PR template that have a low signal/noise ratio,
and add one that I think would have a good signal/noise ratio.

-----
Remove:
Determined the impact on package closure size (by running `nix path-info
-S` before and after)
-----
Rationale:
This is rarely done in practice, and apart from for specific packages
this is usually not a good indicator of anything useful

It might make sense to re-introduce it with two holes to fill, but then
we would have to make a serious decision to never land without these two
numbers filled in or with too big a regression, because in practice this
box has been a no-op in many cases.

Maybe just integrating this check in nixpkgs-review would bring the most
benefit here?
-----

-----
Remove:
Ensured that relevant documentation is up to date
-----
Rationale:
This is fuzzy, “relevant documentation” is way too often hard to find
-----

-----
Add:
Added a release notes entry if the change is major or breaking
-----
Rationale:
This is way too often forgotten, and is also a self-contained easy task
-----
2021-05-21 03:06:21 +02:00
..
ISSUE_TEMPLATE modified out-of-date template 2020-10-22 11:29:39 +02:00
workflows .github/workflows/merge-staging.yml: Include branch in comment 2021-05-13 13:58:14 +02:00
CODEOWNERS pkgs/top-level: init expression for haskell-updates jobset 2021-05-03 11:40:03 +02:00
CONTRIBUTING.md treewide: stdenv.lib -> lib 2021-01-24 01:49:49 +01:00
ISSUE_TEMPLATE.md ISSUE_TEMPLATE: 'nix run' -> 'nix-shell -p' 2020-01-05 22:47:43 +01:00
labeler.yml .github/labeler.yml: Update GNOME file patterns 2021-05-12 19:38:41 +02:00
PULL_REQUEST_TEMPLATE.md pull request template: cleanup (#117537) 2021-05-21 03:06:21 +02:00
STALE-BOT.md STALE-BOT.md: Mention github not notifying 2020-12-09 23:24:02 +02:00
stale.yml stale-bot: TL;DR tweak 2020-10-26 12:58:04 -05:00