3
0
Fork 0
forked from mirrors/nixpkgs
nixpkgs/pkgs
aszlig 948d828955
uqm: Fix purity checking error during config phase
Since commit fb777be7d2, linking programs
in /tmp will no longer work, since with this commit (hardcoded) /tmp
will no longer be treated a valid temporary directory by the purity
checking logic.

Essentially what that logic does is checking whether the link target is
either relative, in some temporary directory or in the Nix store and if
that's not the case, an error is thrown like in this case:

  gcc -c /tmp/build.24.tmp.c -o /tmp/build.24.tmp.c.o
  gcc /tmp/build.24.tmp.c.o -o /tmp/build.24.tmp.out
  impure path `/tmp/build.24.tmp.out' used in link
  collect2: error: ld returned 1 exit status

Note here, that $TMP and $TMPDIR point to /build while the output here
still refers to /tmp. This is because the custom build system of uqm
simply hardcodes /tmp and doesn't honor any of these variables.

To fix this, all we need to do is the latter and we're now using $TMPDIR
instead of /tmp for these compile-tests during configure.

While the pull request[1] introducing said commit has a few comments
regarding other issues and it could still be either reverted or changed,
using $TMPDIR in the uqm build script is entirely backwards-compatible
and shouldn't hurt in any case.

[1]: https://github.com/NixOS/nixpkgs/pull/93560

Signed-off-by: aszlig <aszlig@nix.build>
2020-09-18 12:33:03 +02:00
..
applications Merge pull request #97981 from VirtusLab/git-machete-2.15.5 2020-09-18 10:06:55 +02:00
build-support Merge branch 'master' into staging-next 2020-09-16 17:58:45 +02:00
common-updater
data _3270font: 2.0.4 -> 2.1.0 (#98156) 2020-09-17 19:00:53 -05:00
desktops gnomeExtensions.gsconnect: 39 -> 41 2020-09-17 11:39:07 +03:00
development Merge branch 'staging-next' 2020-09-18 08:12:47 +02:00
games uqm: Fix purity checking error during config phase 2020-09-18 12:33:03 +02:00
misc solfege: fix build with texinfo 6.7 2020-09-18 10:21:24 +00:00
os-specific cpuid: init at 20200427 2020-09-18 09:23:14 +02:00
pkgs-lib
servers Merge pull request #97111 from r-ryantm/auto-update/dolt 2020-09-17 20:29:26 +02:00
shells xonsh: 0.9.21 -> 0.9.22 2020-09-16 18:00:00 -05:00
stdenv Merge pull request #76794 from dudebout/document-nix-env-multiple-output-install-bug 2020-09-05 15:40:26 +02:00
test
tools Merge #97599: bcachefs*: update 2020-09-17 23:20:33 +02:00
top-level cpuid: init at 20200427 2020-09-18 09:23:14 +02:00