3
0
Fork 0
forked from mirrors/nixpkgs
nixpkgs/nixos/modules
Kevin Cox 568d2e77f4
nixos.redis: Fix disabling of RDB persistence.
I was under the impression that setting `services.redis.servers.<name>.save = []` would disable RDB persistence as no schedule would mean no persistence. However since the code did not handle this case specially it actually results in no `save` setting being written and the internal Redis default is used.

This patch handles the empty case to disable RDB persistence.

Disabling RDB persistence is useful in a number of scenarios:

1. Using Redis in a pure-cache mode where persistence is not desired.
2. When using the (generally superior) AOF persistence mode this file is never read so there is little point to writing it.
3. When saving is handled manually

For more information see https://redis.io/docs/manual/persistence/

This is a breaking change as the user may have been relying on `[]` using Redis defaults. However I believe that updating the behaviour for the next release is beneficial as IMHO it is less surprising and does what the user would expect. I have added release notes to warn about this change.
2022-07-05 07:37:38 -04:00
..
config Merge pull request #179204 from jtojnar/no-gtk-xdg-use-portal 2022-06-29 14:24:43 +02:00
hardware ckb-next: remove myself from maintainers (#179573) 2022-07-03 16:07:34 -03:00
i18n/input-method Merge pull request #174218 from NickCao/fcitx5-qt6 2022-06-11 16:20:20 +00:00
installer Merge pull request #176796 from erikarvstedt/improve-netboot-initrd 2022-07-04 09:23:38 +02:00
misc nixos/ids: fix typo in comment 2022-06-28 11:58:47 +00:00
profiles nixos/i18n: don't build all supportedLocales by default 2022-06-11 23:29:29 +02:00
programs nixos/xfconf: init 2022-06-26 14:29:01 -03:00
security Revert "nixos/security/wrappers: use an assertion for the existence check" 2022-06-12 15:38:05 -05:00
services nixos.redis: Fix disabling of RDB persistence. 2022-07-05 07:37:38 -04:00
system nixos: systemd: add missing sliceToUnit (#179841) 2022-07-02 18:56:53 +03:00
tasks Merge pull request #171401 from klemensn/filesystems-zfs 2022-07-03 18:07:53 +02:00
testing nixos/version: Warn about using the default of system.stateVersion 2022-05-05 12:22:31 +02:00
virtualisation nixos/qemu-vm: allow custom partitions and filesystems in VM 2022-07-02 15:37:08 +02:00
module-list.nix Merge pull request #175335 from wyndon/init-lokinet 2022-07-01 11:54:38 +02:00
rename.nix riak, nixos/riak: remove 2022-06-25 15:51:18 -04:00