3
0
Fork 0
forked from mirrors/nixpkgs
nixpkgs/lib/systems
Adam Joseph 36a566b78f lib/systems/parse.nix: mkSkeletonFromList: improve readability
The main purpose of this PR is to make the basis for
`mkSkeletonFromList`'s decision between `cpu-kernel-libcabi` vs
`cpu-vendor-os` clear, without changing its behavior.  The existing
code obscures this decision behind a sequence of prioritized matches
(i.e. `if-then`) which jump around between different coordinates.

Two side benefits of this PR:

1. It makes the root cause of #165836 obvious: we are missing a case
   for `cpu-vendor-libcabi`.  This is why nixpkgs stumbles over
   `*-none-*`.

2. It illuminates some very weird corner cases in the existing
   logic, like `*-${vendor}-ghcjs` overriding the `vendor` field,
   and `mingw32` being transformed into `windows` in some cases.

Co-authored-by: John Ericson <git@JohnEricson.me>
2022-11-13 23:08:57 -08:00
..
architectures.nix
default.nix Merge pull request #82131 from Ericson2314/bsd-cross 2022-11-13 21:35:17 -05:00
doubles.nix lib/systems: Support FreeBSD 2022-11-04 16:49:28 -04:00
examples.nix lib/systems: Support FreeBSD 2022-11-04 16:49:28 -04:00
flake-systems.nix
inspect.nix lib/systems: Support FreeBSD 2022-11-04 16:49:28 -04:00
parse.nix lib/systems/parse.nix: mkSkeletonFromList: improve readability 2022-11-13 23:08:57 -08:00
platforms.nix