3
0
Fork 0
forked from mirrors/nixpkgs
nixpkgs/pkgs/development/tools/misc/libtool/libtool2.nix
Adam Joseph b5aad8addf libtool: fix shebang-fixing from 2.4.7 version bump
Libtool 2.4.7 changed the shebangs in `libtoolize.in` and `ltmain.sh`
from `/bin/sh` (which is a special sandbox exception) to `/usr/bin/env
sh` (which is not).

My PR (#167071) to bump the libtool version adjusted both of these
shebangs, when it should only have adjusted the one in
`libtoolize.in`.

`ltmain.sh` is not a script to be *executed* at
`libtool`-invocation-time.  It is a script which is *vendored into a
release* at `libtoolize`-invocation-time.

Thanks to @trofi for reporting this

  https://github.com/NixOS/nixpkgs/pull/167071#pullrequestreview-1079484605
2022-08-20 20:16:12 -07:00

79 lines
2.3 KiB
Nix

{ lib, stdenv, fetchurl, fetchpatch, autoconf, automake, m4, perl, help2man
, runtimeShell
, file
}:
# Note: this package is used for bootstrapping fetchurl, and thus
# cannot use fetchpatch! All mutable patches (generated by GitHub or
# cgit) that are needed here should be included directly in Nixpkgs as
# files.
stdenv.mkDerivation rec {
pname = "libtool";
version = "2.4.7";
src = fetchurl {
url = "mirror://gnu/libtool/${pname}-${version}.tar.gz";
sha256 = "sha256-BOlsJATqcMWQxUbrpCAqThJyLGQAFsErmy8c49SB6ag=";
};
outputs = [ "out" "lib" ];
# FILECMD was added in libtool 2.4.7; previous versions hardwired `/usr/bin/file`
# https://lists.gnu.org/archive/html/autotools-announce/2022-03/msg00000.html
FILECMD = "${file}/bin/file";
# Normally we'd use autoreconfHook, but that includes libtoolize.
postPatch = ''
aclocal -I m4
automake
autoconf
pushd libltdl
aclocal -I ../m4
automake
autoconf
popd
'' +
# libtool commit da2e352735722917bf0786284411262195a6a3f6 changed
# the shebang from `/bin/sh` (which is a special sandbox exception)
# to `/usr/bin/env sh`, meaning that we now need to patch shebangs
# in libtoolize.in:
''
substituteInPlace libtoolize.in --replace '#! /usr/bin/env sh' '#!${runtimeShell}'
'';
strictDeps = true;
nativeBuildInputs = [ autoconf automake help2man m4 perl ];
propagatedBuildInputs = [ m4 file ];
# Don't fixup "#! /bin/sh" in Libtool, otherwise it will use the
# "fixed" path in generated files!
dontPatchShebangs = true;
dontFixLibtool = true;
# XXX: The GNU ld wrapper does all sorts of nasty things wrt. RPATH, which
# leads to the failure of a number of tests.
doCheck = false;
doInstallCheck = false;
enableParallelBuilding = true;
meta = with lib; {
description = "GNU Libtool, a generic library support script";
longDescription = ''
GNU libtool is a generic library support script. Libtool hides
the complexity of using shared libraries behind a consistent,
portable interface.
To use libtool, add the new generic library building commands to
your Makefile, Makefile.in, or Makefile.am. See the
documentation for details.
'';
homepage = "https://www.gnu.org/software/libtool/";
license = licenses.gpl2Plus;
maintainers = [ ];
platforms = platforms.unix;
};
}