In common distributions, RPATH is only needed for internal libraries so
meson removes everything else. With Nix, the locations of libraries
are not as predictable, therefore we need to keep them in the RPATH. [1]
Previously we have just kept the RPATH produced by the linker, patching
meson not to remove it. This deprived us of potentially replacing it
with install_rpath provided by project so we had to re-add it manually,
and also introduced a vulnerability of keeping build paths in RPATH.
This commit restores the clean-up but modifies it so the items starting
with /nix/store are retained.
This should be relatively safe since the store is immutable, however,
there might be some unwanted retainment of build_rpath [2] if it contains
paths from Nix store.
[1]: https://github.com/NixOS/nixpkgs/issues/31222#issuecomment-365811634
[2]: http://mesonbuild.com/Release-notes-for-0-42-0.html#added-build_rpath-keyword-argument
Remove spl patch that was introduced for grsecurity which we don't support
anymore. ZFS now needs perl for some scripts that are call in the configure
script.
Semi-automatic update generated by https://github.com/ryantm/nix-update tools. These checks were done:
- built on NixOS
- ran `/nix/store/9iss35v7mnmaa30c8lgwahh3vdi7zfgi-CopyQ-3.3.0/bin/copyq -h` got 0 exit code
- ran `/nix/store/9iss35v7mnmaa30c8lgwahh3vdi7zfgi-CopyQ-3.3.0/bin/copyq --help` got 0 exit code
- ran `/nix/store/9iss35v7mnmaa30c8lgwahh3vdi7zfgi-CopyQ-3.3.0/bin/copyq help` got 0 exit code
- ran `/nix/store/9iss35v7mnmaa30c8lgwahh3vdi7zfgi-CopyQ-3.3.0/bin/copyq -v` and found version 3.3.0
- ran `/nix/store/9iss35v7mnmaa30c8lgwahh3vdi7zfgi-CopyQ-3.3.0/bin/copyq --version` and found version 3.3.0
- ran `/nix/store/9iss35v7mnmaa30c8lgwahh3vdi7zfgi-CopyQ-3.3.0/bin/copyq version` and found version 3.3.0
- ran `/nix/store/9iss35v7mnmaa30c8lgwahh3vdi7zfgi-CopyQ-3.3.0/bin/copyq -h` and found version 3.3.0
- ran `/nix/store/9iss35v7mnmaa30c8lgwahh3vdi7zfgi-CopyQ-3.3.0/bin/copyq --help` and found version 3.3.0
- ran `/nix/store/9iss35v7mnmaa30c8lgwahh3vdi7zfgi-CopyQ-3.3.0/bin/copyq help` and found version 3.3.0
- found 3.3.0 with grep in /nix/store/9iss35v7mnmaa30c8lgwahh3vdi7zfgi-CopyQ-3.3.0
- directory tree listing: https://gist.github.com/d350765fb7038f7a4d3810c0ab3825d0
Semi-automatic update generated by https://github.com/ryantm/nix-update tools. These checks were done:
- built on NixOS
- ran `/nix/store/f3718pm1ndwa2bj7q3pdbx01qiday4sj-google-authenticator-libpam-1.05/bin/google-authenticator -h` got 0 exit code
- ran `/nix/store/f3718pm1ndwa2bj7q3pdbx01qiday4sj-google-authenticator-libpam-1.05/bin/google-authenticator --help` got 0 exit code
- ran `/nix/store/f3718pm1ndwa2bj7q3pdbx01qiday4sj-google-authenticator-libpam-1.05/bin/google-authenticator help` got 0 exit code
- directory tree listing: https://gist.github.com/a10c019e5dc879bc33b83175a42ed947
Semi-automatic update generated by https://github.com/ryantm/nix-update tools. These checks were done:
- built on NixOS
- ran `/nix/store/9f6kwyk2zhwhgxkvk2ms8v6g3qz3g154-electron-cash-3.1.6/bin/.electron-cash-wrapped -h` got 0 exit code
- ran `/nix/store/9f6kwyk2zhwhgxkvk2ms8v6g3qz3g154-electron-cash-3.1.6/bin/.electron-cash-wrapped --help` got 0 exit code
- ran `/nix/store/9f6kwyk2zhwhgxkvk2ms8v6g3qz3g154-electron-cash-3.1.6/bin/.electron-cash-wrapped help` got 0 exit code
- ran `/nix/store/9f6kwyk2zhwhgxkvk2ms8v6g3qz3g154-electron-cash-3.1.6/bin/.electron-cash-wrapped version` and found version 3.1.6
- ran `/nix/store/9f6kwyk2zhwhgxkvk2ms8v6g3qz3g154-electron-cash-3.1.6/bin/electron-cash -h` got 0 exit code
- ran `/nix/store/9f6kwyk2zhwhgxkvk2ms8v6g3qz3g154-electron-cash-3.1.6/bin/electron-cash --help` got 0 exit code
- ran `/nix/store/9f6kwyk2zhwhgxkvk2ms8v6g3qz3g154-electron-cash-3.1.6/bin/electron-cash help` got 0 exit code
- ran `/nix/store/9f6kwyk2zhwhgxkvk2ms8v6g3qz3g154-electron-cash-3.1.6/bin/electron-cash version` and found version 3.1.6
- found 3.1.6 with grep in /nix/store/9f6kwyk2zhwhgxkvk2ms8v6g3qz3g154-electron-cash-3.1.6
- directory tree listing: https://gist.github.com/76db342c6da1ceac5b3b7dced43798f9
