Fixes https://github.com/NixOS/nixpkgs/issues/12749
The build failure was caused by brittle detection of the
llvm version. See the code for (excessive) details. This fix
is a quick hack, a proper fix would be to parse the version
of the input llvm derivation and use that to derive a proper
value. Here we just pin the version.
Also move build-time deps to `nativeBuildInputs`.
stdenv.system should be almost always used instead of builtins.currentSystem
or cross-evaluation (e.g. evaluating a i686 NixOS system on a 64-bit nix)
will be subtly broken.
We don't need to wrap twice, because we can actually pass the additional
XDG_DATA_DIRS via makeWrapperArgs.
The reason why I'm doing this within the patchPhase is because we can't
add shell variables from the current builder to makeWrapperArgs as that
content is going to end up in the wrapper verbatim.
In addition to this, gpodder was trying to search for its own directory
using the current program name, which I guess was another reason for the
double-wrap. We fix this now by setting gpodder_dir explicitly in the
main script.
Another main change is that we no longer set the "pythonX.Y-" prefix, so
the derivation name now is just "gpodder-3.9.0".
Last but not least, we enable the unit tests for gpodder in checkPhase.
Signed-off-by: aszlig <aszlig@redmoonstudios.org>
Cc: @svenkeidel
Changes in 3.8.5 (without bug IDs):
* vimeo: Fix vimeo feed discovery
* vimeo: Allow both http and https URLs
* youtube: Improve channel migration code
* youtube: Fix cover art downloading
* Make the YouTube key button link to the gPodder Wiki
* Add pattern to YouTube feed URL list
* CLI: Cleanup old downloads on CLI startup
* Gtk UI: Fix model column data types
* Device sync: Handle sync failure when no space left
* model: Limit filenames to 120 characters for eCryptFS
* rename_download: Add add_sortdate and add_podcast_title option
* Remove the unused 'pipe' IPC module
* Fix coverage usage
* Use Travis CI for running basic sanity tests
* Various small code improvements and fixes
Release announcement for 3.8.5:
http://blog.gpodder.org/2015/12/gpodder-385-casting-agents-and-cowgirls.html
Changes in 3.9.0 (without bug IDs):
* Added Korean translation
* Device sync: Only fail if we can determine free disk space
* Enqueue episodes after download
* Ubuntu AppIndicator extension: 'visible' config option
* gpodder.download: Ignore non-ASCII content-disposition header
* Win32-launcher: Remove download feature (works around Norton warning)
* Remove WebUI, QML UI and MeeGo 1.2 Harmattan support
* Remove broken Flattr integration (use gpodder.net's Flattr support)
* Redesign about dialog
* Preferences: Move video services to separate tab
* Vimeo: Fix Vimeo integration
Release announcement for 3.9.0:
http://blog.gpodder.org/2016/02/gpodder-390-helium-levitator-released.html
Built and tested locally on my machine.
Signed-off-by: aszlig <aszlig@redmoonstudios.org>
Cc: @svenkeidel
