The shell script felt somewhat crammed, with commands and comments on
every line. Grouping commands and comments and giving them some space
feels like an improvement to me.
Previously it would try to run the build before changing directory which would fail to find the nixpkgs default.nix.
Also simplified the script a little to remove the variable that was only used to change directory.
When the path to the Nixpkgs repo contains a space, generate.sh would fail. This can be esily fixed by adding quotes around the variable containing the path.
This will make sure that generate.sh uses the correct version of
node2nix when building nodePackages, since the current version on 19.03
is 1.6.0 and the tree should be built with 1.7.0.
This was supposed to go through a pull request
Revert "nodePackages: Regenerate node packages for nodejs 10 & 12"
This reverts commit 6a17bdf397.
Revert "nodejs-8_x: Drop package"
This reverts commit e06c97b71d.
A full package set is not needed for both node versions. The goal is to
remove the large amount of generated files. Instead only packages which
might be needed in v4 development environments are added to a dedicated
node-packages-v4.json file.