From 3e4b500529732c00fe0c3b33e51a8998fc6f03e6 Mon Sep 17 00:00:00 2001 From: Kevin Quick Date: Wed, 18 Oct 2017 22:04:01 -0700 Subject: [PATCH 1/5] maintainers: add Kevin Quick --- lib/maintainers.nix | 1 + 1 file changed, 1 insertion(+) diff --git a/lib/maintainers.nix b/lib/maintainers.nix index 3116336db902..3565303dca49 100644 --- a/lib/maintainers.nix +++ b/lib/maintainers.nix @@ -323,6 +323,7 @@ konimex = "Muhammad Herdiansyah "; koral = "Koral "; kovirobi = "Kovacsics Robert "; + kquick = "Kevin Quick "; kragniz = "Louis Taylor "; kristoff3r = "Kristoffer Søholm "; ktosiek = "Tomasz Kontusz "; From 6015fdc76aa9061af5c79e23c169072de4df5495 Mon Sep 17 00:00:00 2001 From: Kevin Quick Date: Wed, 18 Oct 2017 23:23:09 -0700 Subject: [PATCH 2/5] theft: add new theft development library package --- pkgs/development/libraries/theft/default.nix | 33 ++++++++++++++++++++ pkgs/top-level/all-packages.nix | 2 ++ 2 files changed, 35 insertions(+) create mode 100644 pkgs/development/libraries/theft/default.nix diff --git a/pkgs/development/libraries/theft/default.nix b/pkgs/development/libraries/theft/default.nix new file mode 100644 index 000000000000..00534413c7bb --- /dev/null +++ b/pkgs/development/libraries/theft/default.nix @@ -0,0 +1,33 @@ +{ stdenv, fetchFromGitHub }: + +stdenv.mkDerivation rec { + version = "0.4.3"; + name = "theft-${version}"; + + src = fetchFromGitHub { + owner = "silentbicycle"; + repo = "theft"; + rev = "v${version}"; + sha256 = "1ibh8np12lafnrsrvjbbzlyq45zq654939x0y22vdnc6s8dpbhw4"; + }; + + preConfigure = "patchShebangs ./scripts/mk_bits_lut"; + # doCheck = true; + + propagatedBuildInputs = [ ]; + + buildInputs = [ ]; + + installFlags = [ "PREFIX=$(out)" ]; + postInstall = '' + install -m644 vendor/greatest.h $out/include/ + ''; + + meta = { + description = "A C library for property-based testing."; + platforms = stdenv.lib.platforms.linux; + homepage = "http://github.com/silentbicycle/theft/"; + license = stdenv.lib.licenses.isc; + maintainers = [ stdenv.lib.maintainers.kquick ]; + }; +} diff --git a/pkgs/top-level/all-packages.nix b/pkgs/top-level/all-packages.nix index a9a3674ee6c1..0be5b4b3c68e 100644 --- a/pkgs/top-level/all-packages.nix +++ b/pkgs/top-level/all-packages.nix @@ -10766,6 +10766,8 @@ with pkgs; tet = callPackage ../development/tools/misc/tet { }; + theft = callPackage ../development/libraries/theft { }; + thrift = callPackage ../development/libraries/thrift { inherit (pythonPackages) twisted; }; From bb47bea024e692ed6c983bda2b48e7a25f377098 Mon Sep 17 00:00:00 2001 From: Kevin Quick Date: Thu, 19 Oct 2017 09:37:10 -0700 Subject: [PATCH 3/5] Enable checks and remove unnecessary lines. --- pkgs/development/libraries/theft/default.nix | 8 +++----- 1 file changed, 3 insertions(+), 5 deletions(-) diff --git a/pkgs/development/libraries/theft/default.nix b/pkgs/development/libraries/theft/default.nix index 00534413c7bb..909df510dff7 100644 --- a/pkgs/development/libraries/theft/default.nix +++ b/pkgs/development/libraries/theft/default.nix @@ -12,12 +12,10 @@ stdenv.mkDerivation rec { }; preConfigure = "patchShebangs ./scripts/mk_bits_lut"; - # doCheck = true; + + doCheck = true; + checkTarget = "test"; - propagatedBuildInputs = [ ]; - - buildInputs = [ ]; - installFlags = [ "PREFIX=$(out)" ]; postInstall = '' install -m644 vendor/greatest.h $out/include/ From 6bfa45997b9bb5c177082d45682ed223c932a123 Mon Sep 17 00:00:00 2001 From: Kevin Quick Date: Thu, 19 Oct 2017 10:01:48 -0700 Subject: [PATCH 4/5] Remove trailing period from description per contribution guidelines. --- pkgs/development/libraries/theft/default.nix | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/pkgs/development/libraries/theft/default.nix b/pkgs/development/libraries/theft/default.nix index 909df510dff7..345401dfa760 100644 --- a/pkgs/development/libraries/theft/default.nix +++ b/pkgs/development/libraries/theft/default.nix @@ -22,7 +22,7 @@ stdenv.mkDerivation rec { ''; meta = { - description = "A C library for property-based testing."; + description = "A C library for property-based testing"; platforms = stdenv.lib.platforms.linux; homepage = "http://github.com/silentbicycle/theft/"; license = stdenv.lib.licenses.isc; From 5e21db46dfe50a55a0bb929342dedbc80beda565 Mon Sep 17 00:00:00 2001 From: Kevin Quick Date: Wed, 25 Oct 2017 16:15:44 -0700 Subject: [PATCH 5/5] Fixed whitespace. --- pkgs/development/libraries/theft/default.nix | 4 +--- 1 file changed, 1 insertion(+), 3 deletions(-) diff --git a/pkgs/development/libraries/theft/default.nix b/pkgs/development/libraries/theft/default.nix index 345401dfa760..a0110c5f22b2 100644 --- a/pkgs/development/libraries/theft/default.nix +++ b/pkgs/development/libraries/theft/default.nix @@ -17,9 +17,7 @@ stdenv.mkDerivation rec { checkTarget = "test"; installFlags = [ "PREFIX=$(out)" ]; - postInstall = '' - install -m644 vendor/greatest.h $out/include/ - ''; + postInstall = "install -m644 vendor/greatest.h $out/include/"; meta = { description = "A C library for property-based testing";