alioth/nixpkgs
3
0
Fork 0
forked from mirrors/nixpkgs
Code Releases Activity

lvm2: Remove dependency on thin-provisioning-tools

Browse source 
thin-provisioning-tools has a _huge_ closure size (hundreds of
megabytes) and the only reference in the output of the lvm2 package is a
_comment_ in the etc/lvm.conf

The lvm2 package thus does not seem to depend on thin-provisoning-tools
in any way.

Reverts 9326a89910

thin provisoning is broken with or without this change:
https://github.com/NixOS/nixpkgs/issues/15516

A proper fix is here:
https://github.com/NixOS/nixpkgs/pull/46541

References:

$ nix why-depends nixpkgs#lvm2 nixpkgs#thin-provisioning-tools
/nix/store/n7zwwxi0ihjks7qk9bq5lbkniligfcqc-lvm2-2.03.11
└───etc/lvm.conf: …_check_executable = "/nix/store/w5an38q6byfr1sihks66srbqdii9hnsd-thin-prov>
    → /nix/store/w5an38q6byfr1sihks66srbqdii9hnsd-thin-provisioning-tools-0.9.0

$ ag thin-provisioning-tools --search-binary
etc/lvm.conf
1093:	# (See package device-mapper-persistent-data or thin-provisioning-tools)
1095:	# thin_check_executable = "/nix/store/w5an38q6byfr1sihks66srbqdii9hnsd-thin-provisioning-tools-0.9.0/bin/thin_check"
1100:	# (See package device-mapper-persistent-data or thin-provisioning-tools)
1102:	# thin_dump_executable = "/nix/store/w5an38q6byfr1sihks66srbqdii9hnsd-thin-provisioning-tools-0.9.0/bin/thin_dump"
1108:	# (See package device-mapper-persistent-data or thin-provisioning-tools)
1110:	# thin_repair_executable = "/nix/store/w5an38q6byfr1sihks66srbqdii9hnsd-thin-provisioning-tools-0.9.0/bin/thin_repair"
1155:	# (See package device-mapper-persistent-data or thin-provisioning-tools)
1157:	# cache_check_executable = "/nix/store/w5an38q6byfr1sihks66srbqdii9hnsd-thin-provisioning-tools-0.9.0/bin/cache_check"
1162:	# (See package device-mapper-persistent-data or thin-provisioning-tools)
1164:	# cache_dump_executable = "/nix/store/w5an38q6byfr1sihks66srbqdii9hnsd-thin-provisioning-tools-0.9.0/bin/cache_dump"
1170:	# (See package device-mapper-persistent-data or thin-provisioning-tools)
1172:	# cache_repair_executable = "/nix/store/w5an38q6byfr1sihks66srbqdii9hnsd-thin-provisioning-tools-0.9.0/bin/cache_repair"
This commit is contained in:
Arian van Putten 2021-05-01 13:38:07 +02:00 committed by Frederik Rietdijk
parent af1211ebc2
commit d5fde7feb6
1 changed files with 2 additions and 2 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

4
pkgs/os-specific/linux/lvm2/default.nix
View file

@ -4,7 +4,7 @@
, pkg-config
, util-linux
, libuuid
, thin-provisioning-tools, libaio
, libaio
, enableCmdlib ? false
, enableDmeventd ? false
, udev ? null
@ -24,7 +24,7 @@ stdenv.mkDerivation rec {
};
nativeBuildInputs = [ pkg-config ];
buildInputs = [ udev libuuid thin-provisioning-tools libaio ];
buildInputs = [ udev libuuid libaio ];
configureFlags = [
"--disable-readline"