From cd0ddefb4382e26c8f8f7bd0acd2c18b2fae94c3 Mon Sep 17 00:00:00 2001
From: sternenseemann <sternenseemann@systemli.org>
Date: Sun, 20 Mar 2022 11:05:56 +0100
Subject: [PATCH] maintainers/haskell/update-stackage.sh: make shellcheck happy
* Annotate shell type
* Make trap expansion safer
---
maintainers/scripts/haskell/update-stackage.sh | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/maintainers/scripts/haskell/update-stackage.sh b/maintainers/scripts/haskell/update-stackage.sh
index c5f9f19c6fd0..0c41b4eec58e 100755
--- a/maintainers/scripts/haskell/update-stackage.sh
+++ b/maintainers/scripts/haskell/update-stackage.sh
@@ -1,5 +1,6 @@
#! /usr/bin/env nix-shell
#! nix-shell -i bash -p nix curl jq nix-prefetch-github git gnused gnugrep -I nixpkgs=.
+# shellcheck shell=bash
set -eu -o pipefail
@@ -13,11 +14,10 @@ toLower() {
}
tmpfile=$(mktemp "update-stackage.XXXXXXX")
-# shellcheck disable=SC2064
stackage_config="pkgs/development/haskell-modules/configuration-hackage2nix/stackage.yaml"
-trap "rm ${tmpfile} ${tmpfile}.new" 0
+trap 'rm "${tmpfile}" "${tmpfile}.new"' 0
touch "$tmpfile" "$tmpfile.new" # Creating files here so that trap creates no errors.
curl -L -s "https://stackage.org/$(toLower "$SOLVER")/cabal.config" >"$tmpfile"