alioth/nixpkgs
3
0
Fork 0
forked from mirrors/nixpkgs
Code Releases Activity

nextcloud-client: switch to libsecret and use it by default

Browse source 
This change makes it easier for users to setup the nextcloud client with
GNOME keyring support as discussed in the IRC[1][2].

Additionaly we now use `libsecret` instead of `libgnome-keyring` which
integrates better in a GNOME setup (libgnome-keyring defaults to the
Gnome2 library)[3].

[1] https://logs.nix.samueldr.com/nixos/2018-11-24#1745871;
[2] https://logs.nix.samueldr.com/nixos/2018-11-24#1746033;
[3] #38266
This commit is contained in:
Maximilian Bosch 2018-11-25 21:26:25 +01:00
parent 21773f1d43
commit c6913213eb
No known key found for this signature in database
GPG key ID: 091DBF4D1FC46B8E
3 changed files with 7 additions and 22 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

9
pkgs/applications/networking/nextcloud-client/default.nix
View file

@ -1,5 +1,5 @@
{ stdenv, fetchgit, cmake, pkgconfig, qtbase, qtwebkit, qtkeychain, qttools, sqlite
, inotify-tools, makeWrapper, libgnome-keyring, openssl_1_1, pcre, qtwebengine
, inotify-tools, makeWrapper, openssl_1_1, pcre, qtwebengine, libsecret
}:
stdenv.mkDerivation rec {
@ -13,7 +13,7 @@ stdenv.mkDerivation rec {
fetchSubmodules = true;
};
nativeBuildInputs = [ pkgconfig cmake ];
nativeBuildInputs = [ pkgconfig cmake makeWrapper ];
buildInputs = [ qtbase qtwebkit qtkeychain qttools qtwebengine sqlite openssl_1_1.out pcre inotify-tools ];
@ -32,7 +32,10 @@ stdenv.mkDerivation rec {
postInstall = ''
sed -i 's/\(Icon.*\)=nextcloud/\1=Nextcloud/g' \
$out/share/applications/nextcloud.desktop
$out/share/applications/nextcloud.desktop
wrapProgram "$out/bin/nextcloud" \
--prefix LD_LIBRARY_PATH : ${stdenv.lib.makeLibraryPath [ libsecret ]}
'';
meta = with stdenv.lib; {

14
pkgs/applications/networking/nextcloud-client/wrapper.nix
View file

@ -1,14 +0,0 @@
{ lib, nextcloud-client, makeWrapper, symlinkJoin, withGnomeKeyring ? false, libgnome-keyring }:
if (!withGnomeKeyring) then nextcloud-client else symlinkJoin {
name = "${nextcloud-client.name}-with-gnome-keyring";
paths = [ nextcloud-client ];
nativeBuildInputs = [ makeWrapper ];
postBuild = ''
wrapProgram "$out/bin/nextcloud" \
--prefix LD_LIBRARY_PATH : ${lib.makeLibraryPath [ libgnome-keyring ]}
'';
inherit (nextcloud-client) meta;
}

6
pkgs/top-level/all-packages.nix
View file

@ -4388,11 +4388,7 @@ with pkgs;
nextcloud = callPackage ../servers/nextcloud { };
nextcloud-client-unwrapped = libsForQt5.callPackage ../applications/networking/nextcloud-client { };
nextcloud-client = callPackage ../applications/networking/nextcloud-client/wrapper.nix {
nextcloud-client = nextcloud-client-unwrapped;
};
nextcloud-client = libsForQt5.callPackage ../applications/networking/nextcloud-client { };
nextcloud-news-updater = callPackage ../servers/nextcloud/news-updater.nix { };