alioth/nixpkgs
3
0
Fork 0
forked from mirrors/nixpkgs
Code Releases Activity

vscode: don't fixup on darwin

Browse source 
Editing the `code` binary within the app bundle causes the bundle's signature to be invalidated, which prevents launching starting with macOS Ventura, because VS Code is notarized.

See https://eclecticlight.co/2022/06/17/app-security-changes-coming-in-ventura/ for more information.
This commit is contained in:
Winter 2022-10-22 13:19:07 -04:00
parent 90e77c45dc
commit b29b81e458
2 changed files with 7 additions and 1 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

3
pkgs/applications/editors/vscode/generic.nix
View file

@ -12,6 +12,7 @@
# Attributes inherit from specific versions
, version, src, meta, sourceRoot, commandLineArgs
, executableName, longName, shortName, pname, updateScript
, dontFixup ? false
# sourceExecutableName is the name of the binary in the source archive, over
# which we have no control
, sourceExecutableName ? executableName
@ -21,7 +22,7 @@ let
inherit (stdenv.hostPlatform) system;
unwrapped = stdenv.mkDerivation {
inherit pname version src sourceRoot;
inherit pname version src sourceRoot dontFixup;
passthru = {
inherit executableName longName tests updateScript;

5
pkgs/applications/editors/vscode/vscode.nix
View file

@ -46,6 +46,11 @@ in
updateScript = ./update-vscode.sh;
# Editing the `code` binary within the app bundle causes the bundle's signature
# to be invalidated, which prevents launching starting with macOS Ventura, because VS Code is notarized.
# See https://eclecticlight.co/2022/06/17/app-security-changes-coming-in-ventura/ for more information.
dontFixup = stdenv.isDarwin;
meta = with lib; {
description = ''
Open source source code editor developed by Microsoft for Windows,