3
0
Fork 0
forked from mirrors/nixpkgs

khal: fix build

* `glibcLocales` (+appropriate locale settings) are needed to fix
  locale/language-related errors in the `checkPhase`.
* The `test_editor.test_popup`-testcase appears to break in
  their testsuite. I confirmed manually that the functionality works, the
  error looks more like a problem related to the mocking-api. Thus I
  disabled the test for now.

https://hydra.nixos.org/build/109705657

Closes #76989
This commit is contained in:
Maximilian Bosch 2020-01-06 17:28:46 +01:00
parent b806f95ce6
commit a6d0b81d28
No known key found for this signature in database
GPG key ID: 091DBF4D1FC46B8E
2 changed files with 32 additions and 7 deletions

View file

@ -1,4 +1,4 @@
{ stdenv, pkgs, python3, fetchpatch }:
{ stdenv, pkgs, python3, fetchpatch, glibcLocales }:
with python3.pkgs; buildPythonApplication rec {
pname = "khal";
@ -11,11 +11,14 @@ with python3.pkgs; buildPythonApplication rec {
# Include a khal.desktop file via upstream commit.
# This patch should be removed when updating to the next version, probably.
patches = [ (fetchpatch {
name = "add-khal-dot-desktop.patch";
url = "https://github.com/pimutils/khal/commit/1f93d238fec7c934dd2f8e48f54925d22130e3aa.patch";
sha256 = "06skn3van7zd93348fc6axllx71ckkc7h2zljqlvwa339vca608c";
}) ];
patches = [
(fetchpatch {
name = "add-khal-dot-desktop.patch";
url = "https://github.com/pimutils/khal/commit/1f93d238fec7c934dd2f8e48f54925d22130e3aa.patch";
sha256 = "06skn3van7zd93348fc6axllx71ckkc7h2zljqlvwa339vca608c";
})
./skip-broken-test.patch
];
propagatedBuildInputs = [
atomicwrites
@ -35,7 +38,8 @@ with python3.pkgs; buildPythonApplication rec {
freezegun
];
nativeBuildInputs = [ setuptools_scm sphinx sphinxcontrib_newsfeed ];
checkInputs = [ pytest ];
checkInputs = [ pytest glibcLocales ];
LC_ALL = "en_US.UTF-8";
postInstall = ''
# zsh completion

View file

@ -0,0 +1,21 @@
diff --git a/tests/ui/test_editor.py b/tests/ui/test_editor.py
index 27b7fa5..5978d72 100644
--- a/tests/ui/test_editor.py
+++ b/tests/ui/test_editor.py
@@ -1,5 +1,7 @@
import datetime as dt
+import pytest
+
import icalendar
from khal.ui.editor import RecurrenceEditor, StartEndEditor
@@ -19,7 +21,7 @@ palette = {
'edit': 'blue',
}
-
+@pytest.mark.skip(reason="Mocking breaks in this testcase")
def test_popup(monkeypatch):
"""making sure the popup calendar gets callend with the right inital value