Merge pull request #236547 from fabaff/favicon-pytest-runner

python311Packages.favicon: remove pytest-runner

pkgs/development/python-modules/favicon/default.nix

@@ -1,26 +1,47 @@
-{ lib, buildPythonPackage, fetchPypi, requests, beautifulsoup4, pytest, requests-mock,
-  pytest-runner }:
+{ lib
+, beautifulsoup4
+, buildPythonPackage
+, fetchPypi
+, pytestCheckHook
+, pythonOlder
+, requests
+, requests-mock
+}:
 
 buildPythonPackage rec {
   pname = "favicon";
   version = "0.7.0";
+  format = "setuptools";
+
+  disabled = pythonOlder "3.7";
 
   src = fetchPypi {
     inherit pname version;
-    sha256 = "6d6b5a78de2a0d0084589f687f384b2ecd6a6527093fec564403b1a30605d7a8";
+    hash = "sha256-bWtaeN4qDQCEWJ9ofzhLLs1qZScJP+xWRAOxowYF16g=";
   };
 
-  buildInputs = [ pytest-runner ];
-  nativeCheckInputs = [ pytest requests-mock ];
-  propagatedBuildInputs = [ requests beautifulsoup4 ];
-
-  checkPhase = ''
-    pytest
+  postPatch = ''
+    sed -i "/pytest-runner/d" setup.py
   '';
 
+  propagatedBuildInputs = [
+    beautifulsoup4
+    requests
+  ];
+
+  nativeCheckInputs = [
+    pytestCheckHook
+    requests-mock
+  ];
+
+  pythonImportsCheck = [
+    "favicon"
+  ];
+
   meta = with lib; {
     description = "Find a website's favicon";
     homepage = "https://github.com/scottwernervt/favicon";
+    changelog = "https://github.com/scottwernervt/favicon/blob/${version}/CHANGELOG.rst";
     license = licenses.mit;
     maintainers = with maintainers; [ elohmeier ];
   };