From 58dbaf69b7abd7a3483d47bd4eede02d68fcdc78 Mon Sep 17 00:00:00 2001 From: zimbatm Date: Sat, 20 Feb 2016 00:19:49 +0000 Subject: [PATCH 1/2] go: remove ssl certs patches Those are not needed since we now use a standard location to store our bundles. See bfebc7342e42ebe7a57c9e21b11ab19579189bfd --- pkgs/development/compilers/go/1.4.nix | 1 - pkgs/development/compilers/go/1.5.nix | 1 - pkgs/development/compilers/go/cacert-1.4.patch | 14 -------------- pkgs/development/compilers/go/cacert-1.5.patch | 8 -------- 4 files changed, 24 deletions(-) delete mode 100644 pkgs/development/compilers/go/cacert-1.4.patch delete mode 100644 pkgs/development/compilers/go/cacert-1.5.patch diff --git a/pkgs/development/compilers/go/1.4.nix b/pkgs/development/compilers/go/1.4.nix index d25001697443..77349a810845 100644 --- a/pkgs/development/compilers/go/1.4.nix +++ b/pkgs/development/compilers/go/1.4.nix @@ -84,7 +84,6 @@ stdenv.mkDerivation rec { ''; patches = [ - ./cacert-1.4.patch ./remove-tools-1.4.patch ]; diff --git a/pkgs/development/compilers/go/1.5.nix b/pkgs/development/compilers/go/1.5.nix index 54c8cf219d5f..b5bfac850280 100644 --- a/pkgs/development/compilers/go/1.5.nix +++ b/pkgs/development/compilers/go/1.5.nix @@ -89,7 +89,6 @@ stdenv.mkDerivation rec { ''; patches = [ - ./cacert-1.5.patch ./remove-tools-1.5.patch ] # -ldflags=-s is required to compile on Darwin, see diff --git a/pkgs/development/compilers/go/cacert-1.4.patch b/pkgs/development/compilers/go/cacert-1.4.patch deleted file mode 100644 index 5346d3f39505..000000000000 --- a/pkgs/development/compilers/go/cacert-1.4.patch +++ /dev/null @@ -1,14 +0,0 @@ -Go comes with hardcoded cacert. We add the usual in NixOS, -for easier NixOS life. - -diff -r 14854533dcc7 src/crypto/x509/root_unix.go ---- a/src/crypto/x509/root_unix.go Thu Dec 11 11:27:56 2014 +1100 -+++ b/src/crypto/x509/root_unix.go Tue Jan 06 00:41:31 2015 -0600 -@@ -17,6 +17,7 @@ - "/usr/local/share/certs/ca-root-nss.crt", // FreeBSD/DragonFly - "/etc/pki/tls/cacert.pem", // OpenELEC - "/etc/certs/ca-certificates.crt", // Solaris 11.2+ -+ "/etc/ssl/certs/ca-bundle.crt", // NixOS - } - - // Possible directories with certificate files; stop after successfully diff --git a/pkgs/development/compilers/go/cacert-1.5.patch b/pkgs/development/compilers/go/cacert-1.5.patch deleted file mode 100644 index 32c322a104e6..000000000000 --- a/pkgs/development/compilers/go/cacert-1.5.patch +++ /dev/null @@ -1,8 +0,0 @@ ---- a/src/crypto/x509/root_linux.go 2015-08-19 23:06:11.115133174 +0200 -+++ b/src/crypto/x509/root_linux.go 2015-08-19 23:07:04.238507161 +0200 -@@ -10,4 +10,5 @@ - "/etc/pki/tls/certs/ca-bundle.crt", // Fedora/RHEL - "/etc/ssl/ca-bundle.pem", // OpenSUSE - "/etc/pki/tls/cacert.pem", // OpenELEC -+ "/etc/ssl/certs/ca-bundle.crt", // NixOS - } From accc1f1484ad6721d03063d148ea46c85dc76a68 Mon Sep 17 00:00:00 2001 From: zimbatm Date: Sat, 20 Feb 2016 01:04:42 +0000 Subject: [PATCH 2/2] go: 1.4: disable failing test in sandbox --- pkgs/development/compilers/go/1.4.nix | 2 ++ 1 file changed, 2 insertions(+) diff --git a/pkgs/development/compilers/go/1.4.nix b/pkgs/development/compilers/go/1.4.nix index 77349a810845..9c6bbba24d5d 100644 --- a/pkgs/development/compilers/go/1.4.nix +++ b/pkgs/development/compilers/go/1.4.nix @@ -46,6 +46,8 @@ stdenv.mkDerivation rec { sed -i 's,/bin/pwd,'"`type -P pwd`", src/os/os_test.go # Disable the unix socket test sed -i '/TestShutdownUnix/areturn' src/net/net_test.go + # Disable network timeout test + sed -i '/TestDialTimeout/areturn' src/net/dial_test.go # Disable the hostname test sed -i '/TestHostname/areturn' src/os/os_test.go # ParseInLocation fails the test