forked from mirrors/nixpkgs
treewide: Fix 'lib.optional' misuses
These add a singleton list of a package to buildInputs.
This commit is contained in:
parent
c61cc2d56c
commit
5bf5de58ea
|
@ -13,7 +13,7 @@ stdenv.mkDerivation rec {
|
|||
installFlags = "PREFIX=$(out) INSTALL=install";
|
||||
|
||||
buildInputs = []
|
||||
++ stdenv.lib.optional stdenv.isDarwin [ IOKit ];
|
||||
++ stdenv.lib.optional stdenv.isDarwin IOKit;
|
||||
|
||||
meta = with stdenv.lib; {
|
||||
homepage = http://linukz.org/cd-discid.shtml;
|
||||
|
|
|
@ -12,7 +12,7 @@ stdenv.mkDerivation rec {
|
|||
outputs = [ "out" "doc" ];
|
||||
|
||||
nativeBuildInputs = [ makeWrapper xorg.libXt ]
|
||||
++ stdenv.lib.optional doCheck [ perlPackages.TestCommand perlPackages.TestHarness ];
|
||||
++ stdenv.lib.optionals doCheck [ perlPackages.TestCommand perlPackages.TestHarness ];
|
||||
|
||||
buildInputs = [ xorg.libX11 xorg.libXinerama imlib2 libjpeg libpng curl libexif ];
|
||||
|
||||
|
|
|
@ -14,7 +14,7 @@ stdenv.mkDerivation rec {
|
|||
};
|
||||
|
||||
buildInputs = [ makeWrapper jre pythonPackages.python pythonPackages.numpy ]
|
||||
++ optional mesosSupport [ mesos ];
|
||||
++ optional mesosSupport mesos;
|
||||
|
||||
untarDir = "${name}-bin-cdh4";
|
||||
installPhase = ''
|
||||
|
|
|
@ -104,7 +104,7 @@ let
|
|||
"CONFIG+=no-client"
|
||||
];
|
||||
|
||||
buildInputs = [ libcap ] ++ optional iceSupport [ zeroc_ice ];
|
||||
buildInputs = [ libcap ] ++ optional iceSupport zeroc_ice;
|
||||
};
|
||||
|
||||
stableSource = rec {
|
||||
|
|
|
@ -36,7 +36,7 @@ stdenv.mkDerivation rec {
|
|||
[ expat glib cairo pango gdk_pixbuf atk at_spi2_atk
|
||||
libXrandr libXrender libXcomposite libXi libXcursor libSM libICE ]
|
||||
++ optionals waylandSupport [ wayland wayland-protocols ]
|
||||
++ optional stdenv.isDarwin (with darwin.apple_sdk.frameworks; [ AppKit Cocoa ])
|
||||
++ optionals stdenv.isDarwin (with darwin.apple_sdk.frameworks; [ AppKit Cocoa ])
|
||||
++ optional xineramaSupport libXinerama
|
||||
++ optional cupsSupport cups;
|
||||
#TODO: colord?
|
||||
|
|
|
@ -18,7 +18,7 @@ stdenv.mkDerivation rec {
|
|||
outputs = [ "out" "dev" ];
|
||||
|
||||
buildInputs = [ libxml2 libgsf bzip2 libcroco pango libintlOrEmpty ]
|
||||
++ stdenv.lib.optional enableIntrospection [ gobjectIntrospection ];
|
||||
++ stdenv.lib.optional enableIntrospection gobjectIntrospection;
|
||||
|
||||
propagatedBuildInputs = [ glib gdk_pixbuf cairo ] ++ lib.optional withGTK gtk3;
|
||||
|
||||
|
|
|
@ -21,7 +21,7 @@ stdenv.mkDerivation rec {
|
|||
buildInputs = [ cmake ]
|
||||
++ optional alsaSupport alsaLib
|
||||
++ optional pulseSupport libpulseaudio
|
||||
++ optional stdenv.isDarwin [ CoreServices AudioUnit AudioToolbox ];
|
||||
++ optionals stdenv.isDarwin [ CoreServices AudioUnit AudioToolbox ];
|
||||
|
||||
NIX_LDFLAGS = []
|
||||
++ optional alsaSupport "-lasound"
|
||||
|
|
|
@ -22,7 +22,7 @@ stdenv.mkDerivation rec {
|
|||
postCheck = "cat test/test.log";
|
||||
|
||||
buildInputs = [ ]
|
||||
++ stdenv.lib.optional docSupport [ doxygen ];
|
||||
++ stdenv.lib.optional docSupport doxygen;
|
||||
|
||||
propagatedBuildInputs = [ libpng ];
|
||||
|
||||
|
|
|
@ -38,7 +38,7 @@ stdenv.mkDerivation rec {
|
|||
|
||||
nativeBuildInputs = [ pkgconfig makeWrapper ];
|
||||
buildInputs = [ SDL libpng xz zlib freetype fontconfig ]
|
||||
++ stdenv.lib.optional withFluidSynth [ fluidsynth soundfont-fluid ];
|
||||
++ stdenv.lib.optionals withFluidSynth [ fluidsynth soundfont-fluid ];
|
||||
|
||||
prefixKey = "--prefix-dir=";
|
||||
|
||||
|
|
|
@ -53,7 +53,7 @@ stdenv.mkDerivation rec {
|
|||
++ optional withGssapiPatches gssapiSrc;
|
||||
|
||||
buildInputs = [ zlib openssl libedit pkgconfig pam ]
|
||||
++ optional withKerberos [ kerberos ];
|
||||
++ optional withKerberos kerberos;
|
||||
|
||||
# I set --disable-strip because later we strip anyway. And it fails to strip
|
||||
# properly when cross building.
|
||||
|
|
|
@ -10,7 +10,7 @@ stdenv.mkDerivation rec {
|
|||
};
|
||||
|
||||
buildInputs = [ makeWrapper perl LWP URI HTMLParser ]
|
||||
++ stdenv.lib.optional doCheck [ HTTPServerSimple Parent ];
|
||||
++ stdenv.lib.optionals doCheck [ HTTPServerSimple Parent ];
|
||||
|
||||
configurePhase = ''
|
||||
for i in swec tests/{runTests,testServer}
|
||||
|
|
|
@ -11,7 +11,7 @@ stdenv.mkDerivation rec {
|
|||
};
|
||||
|
||||
buildInputs = with pkgs; [ unzip ]
|
||||
++ stdenv.lib.optional stdenv.isDarwin [ darwin.apple_sdk.frameworks.Cocoa ];
|
||||
++ stdenv.lib.optionals stdenv.isDarwin [ darwin.apple_sdk.frameworks.Cocoa ];
|
||||
patches = [ ./casts.patch ];
|
||||
setSourceRoot = "sourceRoot=${product}-source-${version}";
|
||||
buildPhase = "bash build";
|
||||
|
|
|
@ -32,7 +32,7 @@ let self = _self // overrides; _self = with self; {
|
|||
};
|
||||
outputs = ["out" "doc"];
|
||||
# use gnused so that the preCheck command passes
|
||||
buildInputs = stdenv.lib.optional stdenv.isDarwin [ gnused ];
|
||||
buildInputs = stdenv.lib.optional stdenv.isDarwin gnused;
|
||||
propagatedBuildInputs = [ FileNext ];
|
||||
meta = with stdenv.lib; {
|
||||
description = "A grep-like tool tailored to working with large trees of source code";
|
||||
|
|
|
@ -2016,7 +2016,7 @@ in modules // {
|
|||
};
|
||||
|
||||
propagatedBuildInputs = with stdenv.lib; with pkgs; [ modules.curses zlib xz ncompress gzip bzip2 gnutar p7zip cabextract lzma self.pycrypto ]
|
||||
++ optional visualizationSupport [ pyqtgraph ];
|
||||
++ optional visualizationSupport pyqtgraph;
|
||||
|
||||
meta = with stdenv.lib; {
|
||||
homepage = "http://binwalk.org";
|
||||
|
|
Loading…
Reference in a new issue