alioth/nixpkgs
3
0
Fork 0
forked from mirrors/nixpkgs
Code Releases Activity

openvscode-server: revert #232887

Browse source 
switch back to NodeJS 16 since microsoft/vscode does not support NodeJS 18 yet
This commit is contained in:
Pol Dellaiera 2023-05-31 09:46:12 +02:00
parent 9411636748
commit 1e708950b0
No known key found for this signature in database
GPG key ID: D476DFE9C67467CA
2 changed files with 5 additions and 2 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

5
pkgs/servers/openvscode-server/default.nix
View file

@ -107,6 +107,9 @@ in stdenv.mkDerivation rec {
# set offline mirror to yarn cache we created in previous steps
yarn --offline config set yarn-offline-mirror "${yarnCache}"
# set nodedir, so we can build binaries later
npm config set nodedir "${nodejs}"
'';
buildPhase = ''
@ -143,7 +146,7 @@ in stdenv.mkDerivation rec {
# rebuild binaries, we use npm here, as yarn does not provide an alternative
# that would not attempt to try to reinstall everything and break our
# patching attempts
npm --prefix ./remote rebuild --build-from-source --nodedir ${nodejs}
npm --prefix ./remote rebuild --build-from-source
# run postinstall scripts after patching
find . -path "*node_modules" -prune -o \

2
pkgs/top-level/all-packages.nix
View file

@ -35134,7 +35134,7 @@ with pkgs;
vscodium-fhsWithPackages = vscodium.fhsWithPackages;
openvscode-server = callPackage ../servers/openvscode-server {
nodejs = nodejs_18;
nodejs = nodejs_16;
inherit (darwin.apple_sdk.frameworks) AppKit Cocoa Security;
inherit (darwin) cctools;
};