alioth/nixpkgs
3
0
Fork 0
forked from mirrors/nixpkgs
Code Releases Activity

freedroidrpg: remove build-time flags embedding into binary

Browse source 
Noticed extra -dev dependencies in the runtime closure.

Before the change:

    $ nix path-info -rsSh $(nix-build -A freedroidrpg) | nl | tail -n1 | unnix
    158  /<<NIX>>/freedroidrpg-0.16.1 228.2M  808.1M

After the change:

    $ nix path-info -rsSh $(nix-build -A freedroidrpg) | nl | tail -n1 | unnix
    141  /<<NIX>>/freedroidrpg-0.16.1 228.2M  450.7M
This commit is contained in:
Sergei Trofimovich 2022-09-18 16:39:48 +01:00
parent 9c2a7cc09d
commit 02ba9a3d60
2 changed files with 18 additions and 0 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

3
pkgs/games/freedroidrpg/default.nix
View file

@ -18,6 +18,9 @@ in stdenv.mkDerivation {
url = "https://gitlab.com/freedroid/freedroid-src/-/commit/e610d427374226b79da5258d979936459f30c761.patch";
sha256 = "1s7sw4dkc7b6i72j6x47driq6v0k3wss48l9ivd4fw40n3iaxjb1";
})
# Do not embed build flags in the binary to reduce closure size.
./drop-build-deps.patch
];
nativeBuildInputs = [ pkg-config gettext python3 ];

15
pkgs/games/freedroidrpg/drop-build-deps.patch Normal file
View file

@ -0,0 +1,15 @@
Do not embed paths to build-only depends (-I...SDL2-dev and friends)
into savefile lua comments.
--- a/src/savestruct_internal.c
+++ b/src/savestruct_internal.c
@@ -486,8 +486,8 @@ void save_game_data(struct auto_string *strout)
autostr_append(strout,
"SAVEGAME: %s %s %s;sizeof(tux_t)=%d;sizeof(enemy)=%d;sizeof(bullet)=%d;MAXBULLETS=%d\n",
SAVEGAME_VERSION, SAVEGAME_REVISION, VERSION, (int)sizeof(tux_t), (int)sizeof(enemy), (int)sizeof(bullet), (int)MAXBULLETS);
- autostr_append(strout, "BUILD_CFLAGS: %s\n", BUILD_CFLAGS);
- autostr_append(strout, "BUILD_LDFLAGS: %s\n", BUILD_LDFLAGS);
+ autostr_append(strout, "BUILD_CFLAGS: %s\n", "<hidden>");
+ autostr_append(strout, "BUILD_LDFLAGS: %s\n", "<hidden>");
autostr_append(strout, "VERSION: %s\n", freedroid_version);
autostr_append(strout, "--]]\n");